From: Pavel Machek <pavel@denx.de>
To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
tomm.merciai@gmail.com
Subject: Re: [PATCH 6.1.y-cip 07/17] mmc: renesas_sdhi: take DMA end interrupts into account
Date: Tue, 24 Jun 2025 10:44:37 +0200 [thread overview]
Message-ID: <aFpldcyO4dPmbwih@duo.ucw.cz> (raw)
In-Reply-To: <20250623144639.2119707-8-tommaso.merciai.xr@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
Hi!
> commit c330601c9c93392000c077d973b182cc0164b9ac upstream.
>
> So far, we have been relying on access_end interrupts only to mark DMA
> transfers as done implying that DMA end interrupts have occurred by then
> anyhow. On some SoCs under some conditions, this turned out to be not
> enough. So, we enable DMA interrupts as well and make sure that both
> events, DMA irq and access_end irq, have happened before finishing the
> DMA transfer.
> + u32 dma_irqs = INFO1_DTRANEND0 |
> + (priv->quirks && priv->quirks->old_info1_layout ?
> + INFO1_DTRANEND1_OLD : INFO1_DTRANEND1);
>
This expression is ... fun enough to deserve macro or inline
function. It got better in follow up patches, but may be still worth
macro/inline.
Anyway, this is nothing to block the merge.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2025-06-24 8:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 14:46 [PATCH 6.1.y-cip 00/17] Add support for RZ/G3E SDHI Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 01/17] clk: renesas: r9a09g047: Add SDHI clocks/resets Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 02/17] dt-bindings: mmc: renesas,sdhi: Document RZ/G3E support Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 03/17] of: base: Add of_get_available_child_by_name() Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 04/17] mmc: tmio: add callback for dma irq Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 05/17] mmc: renesas_sdhi: improve naming of DMA struct Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 06/17] mmc: renesas_sdhi: remove accessor function for internal_dmac Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 07/17] mmc: renesas_sdhi: take DMA end interrupts into account Tommaso Merciai
2025-06-24 8:44 ` Pavel Machek [this message]
2025-06-23 14:46 ` [PATCH 6.1.y-cip 08/17] mmc: renesas_sdhi: add helper to access quirks Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 09/17] mmc: renesas_sdhi: use plain numbers for end_flags Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 10/17] mmc: renesas_sdhi: use typedef for dma_filter_fn Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 11/17] mmc: renesas_sdhi: Add support for RZ/G3E SoC Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 12/17] mmc: renesas_sdhi: Use of_get_available_child_by_name() Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 13/17] arm64: dts: renesas: r9a09g047: Add SDHI0-SDHI2 nodes Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 14/17] arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal regulator Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 15/17] arm64: dts: renesas: rzg3e-smarc-som: Enable SDHI{0,2} Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 16/17] arm64: dts: renesas: rzg3e-smarc-som: Add support to enable SD on SDHI0 Tommaso Merciai
2025-06-23 14:46 ` [PATCH 6.1.y-cip 17/17] arm64: dts: renesas: r9a09g047e57-smarc: Enable SDHI1 Tommaso Merciai
2025-06-24 7:24 ` [PATCH 6.1.y-cip 00/17] Add support for RZ/G3E SDHI nobuhiro1.iwamatsu
2025-06-24 15:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFpldcyO4dPmbwih@duo.ucw.cz \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tomm.merciai@gmail.com \
--cc=tommaso.merciai.xr@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox