Re: [PATCH 6.1.y-cip 07/17] mmc: renesas_sdhi: take DMA end interrupts into account

Pavel Machek
2025-06-24T08:44:46Z

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

Hi!

> commit c330601c9c93392000c077d973b182cc0164b9ac upstream.
>
> So far, we have been relying on access_end interrupts only to mark DMA
> transfers as done implying that DMA end interrupts have occurred by then
> anyhow. On some SoCs under some conditions, this turned out to be not
> enough. So, we enable DMA interrupts as well and make sure that both
> events, DMA irq and access_end irq, have happened before finishing the
> DMA transfer.

> + u32 dma_irqs = INFO1_DTRANEND0 |
> + (priv->quirks && priv->quirks->old_info1_layout ?
> + INFO1_DTRANEND1_OLD : INFO1_DTRANEND1);
>

This expression is ... fun enough to deserve macro or inline
function. It got better in follow up patches, but may be still worth
macro/inline.

Anyway, this is nothing to block the merge.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]