RE: [PATCH 6.1.y-cip 00/17] Add support for RZ/G3E SDHI

nobuhiro1.iwamatsu
2025-06-24T07:25:06Z

Hi,

> -----Original Message-----
> From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> Sent: Monday, June 23, 2025 11:46 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○
> ＣＰＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>; tomm.merciai@gmail.com
> Subject: [PATCH 6.1.y-cip 00/17] Add support for RZ/G3E SDHI
>
> Hi All,
>
> This patch series aims to add SDHI support for the Renesas RZ/G3E SoCs into
> the linux-6.1.y-cip kernel.
>
> The SD/MMC block on the RZ/G3E ("R9A09G047") SoC is similar to that of the
> RZ/V2H, but the SD0 channel has only dedicated pins, so we must use
> SD_STATUS register to control voltage and power enable (internal regulator).
>
> For SD1 and SD2 channel we can either use gpio regulator or internal regulator
> (using SD_STATUS register) for voltage switching.
>
> This patchset applies on top of [1]
>
> [1] https://patchwork.kernel.org/project/cip-dev/list/?series=974771
>
> Thanks & Regards,
> Tommaso
> Biju Das (10):
> clk: renesas: r9a09g047: Add SDHI clocks/resets
> dt-bindings: mmc: renesas,sdhi: Document RZ/G3E support
> of: base: Add of_get_available_child_by_name()
> mmc: renesas_sdhi: Add support for RZ/G3E SoC
> mmc: renesas_sdhi: Use of_get_available_child_by_name()
> arm64: dts: renesas: r9a09g047: Add SDHI0-SDHI2 nodes
> arm64: dts: renesas: r9a09g057: Add support for enabling SDHI internal
> regulator
> arm64: dts: renesas: rzg3e-smarc-som: Enable SDHI{0,2}
> arm64: dts: renesas: rzg3e-smarc-som: Add support to enable SD on
> SDHI0
> arm64: dts: renesas: r9a09g047e57-smarc: Enable SDHI1
>
> Krzysztof Kozlowski (1):
> mmc: renesas_sdhi: use typedef for dma_filter_fn
>
> Wolfram Sang (6):
> mmc: tmio: add callback for dma irq
> mmc: renesas_sdhi: improve naming of DMA struct
> mmc: renesas_sdhi: remove accessor function for internal_dmac
> mmc: renesas_sdhi: take DMA end interrupts into account
> mmc: renesas_sdhi: add helper to access quirks
> mmc: renesas_sdhi: use plain numbers for end_flags
>
> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 16 ++
> arch/arm64/boot/dts/renesas/r9a09g047.dtsi | 60 +++++++
> .../boot/dts/renesas/r9a09g047e57-smarc.dts | 49 ++++++
> arch/arm64/boot/dts/renesas/r9a09g057.dtsi | 21 +++
> .../boot/dts/renesas/renesas-smarc2.dtsi | 18 ++
> .../boot/dts/renesas/rzg3e-smarc-som.dtsi | 154
> ++++++++++++++++++
> drivers/clk/renesas/r9a09g047-cpg.c | 31 ++++
> drivers/mmc/host/Kconfig | 2 +-
> drivers/mmc/host/renesas_sdhi.h | 20 ++-
> drivers/mmc/host/renesas_sdhi_core.c | 148
> +++++++++++++++--
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 82 ++++++----
> drivers/mmc/host/tmio_mmc.h | 11 ++
> drivers/mmc/host/tmio_mmc_core.c | 3 +
> drivers/of/base.c | 27 +++
> include/linux/of.h | 9 +
> 15 files changed, 605 insertions(+), 46 deletions(-)
>
I reviewed this series, looks good to me. I can apply, if there are no other comments.
Test: https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/1885943849

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
Nobuhiro