Re: [PATCH 6.1.y-cip 07/25] pinctrl: renesas: rzg2l: Unify OEN access by making pin-to-bit mapping configurable

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

Hi!

> Refactor the RZG2L pinctrl driver to support reuse of the common
> rzg2l_read_oen() and rzg2l_write_oen() helpers across SoCs with
> different output-enable (OEN) bit mappings.
> 
> Introduce a new `pin_to_oen_bit` callback in `struct rzg2l_pinctrl_data`
> to allow SoCs to provide custom logic for mapping a pin to its OEN bit.
> Update the generic OEN read/write paths to use this callback when
> present.

> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -1063,7 +1064,10 @@ static u32 rzg2l_read_oen(struct rzg2l_pinctrl *pctrl, unsigned int _pin)
>  {
>  	int bit;
>  
> -	bit = rzg2l_pin_to_oen_bit(pctrl, _pin);
> +	if (!pctrl->data->pin_to_oen_bit)
> +		return 0;
> +
> +	bit = pctrl->data->pin_to_oen_bit(pctrl, _pin);
>  	if (bit < 0)
>  		return 0;
>

Returning success on failure... is strange, but I believe that is
changed in later patches.

> @@ -1077,9 +1081,12 @@ static int rzg2l_write_oen(struct rzg2l_pinctrl *pctrl, unsigned int _pin, u8 oe
>  	int bit;
>  	u8 val;
>  
> -	bit = rzg2l_pin_to_oen_bit(pctrl, _pin);
> +	if (!pctrl->data->pin_to_oen_bit)
> +		return -EINVAL;
> +
> +	bit = pctrl->data->pin_to_oen_bit(pctrl, _pin);
>  	if (bit < 0)
> -		return bit;
> +		return -EINVAL;
>  
>  	spin_lock_irqsave(&pctrl->lock, flags);
>  	val = readb(pctrl->base + oen_offset);

But his one is ugly. Any error return is converted to -EINVAL here.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]