Re: [PATCH 6.1.y-cip 12/25] pinctrl: renesas: rzg2l: Fix OEN resume

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]

Hi!

> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> [ Upstream commit 30247fc3254a4502465ab809d49e2167ace5a6f2 ]
> 
> Writing to the PFC_OEN register is controlled by the write protect
> register (PWPR).  Currently the OEN register write in resume() is done
> without enabling write access in PWPR leading to incorrect
> operation.

> @@ -3150,7 +3152,16 @@ static int rzg2l_pinctrl_resume_noirq(struct device *dev)
>  	}
>  
>  	writeb(cache->qspi, pctrl->base + QSPI);
> +	if (pctrl->data->hwcfg->oen_pwpr_lock) {
> +		spin_lock_irqsave(&pctrl->lock, flags);
> +		pwpr = readb(pctrl->base + regs->pwpr);
> +		writeb(pwpr | PWPR_REGWE_B, pctrl->base + regs->pwpr);
> +	}
>  	writeb(cache->oen, pctrl->base + pctrl->data->hwcfg->regs.oen);
> +	if (pctrl->data->hwcfg->oen_pwpr_lock) {
> +		writeb(pwpr & ~PWPR_REGWE_B, pctrl->base + regs->pwpr);
> +		spin_unlock_irqrestore(&pctrl->lock, flags);
> +	}
>  	for (u8 i = 0; i < 2; i++) {
>  		if (regs->sd_ch)
>  			writeb(cache->sd_ch[i], pctrl->base +
>  	SD_CH(regs->sd_ch, i));

This is "interesting" piece of code (just take the spinlock always?),
plus we already have similar code in rzg2l_write_oen, could it be
shared?

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]