Re: [PATCH 5.10.y-cip 2/2] ASoC: renesas: rz-ssi: Use proper dma_buffer_pos after resume

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

On Mon 2025-11-24 15:23:41, Claudiu Beznea wrote:
> Hi, Pavel,
> 
> On 11/24/25 12:21, Pavel Machek wrote:
> > Hi!
> > 
> >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >>
> >> commit 22897e568646de5907d4981eae6cc895be2978d1 upstream.
> >>
> >> When the driver supports DMA, it enqueues four DMA descriptors per
> >> substream before the substream is started. New descriptors are enqueued in
> >> the DMA completion callback, and each time a new descriptor is queued, the
> >> dma_buffer_pos is incremented.
> >>
> >> During suspend, the DMA transactions are terminated. There might be cases
> >> where the four extra enqueued DMA descriptors are not completed and are
> >> instead canceled on suspend. However, the cancel operation does not take
> >> into account that the dma_buffer_pos was already incremented.
> > 
> > Ok. So if you suspend the board in the middle of music playback, few
> > notes may be dropped or something?
> 
> Yes, few samples from the audio buffer will be dropped.
> 
> > Don't do that, then. Suspending in
> > the middle of audio playback will sound horrible, anyway.
> 
> OK.
> 
> I think audio subsystem is trying its best to avoid glitches and other
> unwanted sounds.

Yep, no problem, we can easily apply this. Its just... suspending
while audio is playing will not be ok either way.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]