From: Pavel Machek <pavel@denx.de>
To: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: "Nobuhiro Iwamatsu (Toshiba)" <iwamatsu@gmail.com>,
nobuhiro1.iwamatsu@toshiba.co.jp, cip-dev@lists.cip-project.org
Subject: Re: [cip-dev] [PATCH 5.10.y-cip 1/2] ASoC: da7213: Use component driver suspend/resume
Date: Tue, 25 Nov 2025 13:43:29 +0100 [thread overview]
Message-ID: <aSWkcdhsz1ldyWqw@duo.ucw.cz> (raw)
In-Reply-To: <401dab8e-a50f-4c76-8997-a311e818e81e@tuxon.dev>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi!
> >> +static int da7213_runtime_suspend(struct device *dev)
> >> +{
> >> + struct da7213_priv *da7213 = dev_get_drvdata(dev);
> >> +
> >> + regcache_cache_only(da7213->regmap, true);
> >> + regcache_mark_dirty(da7213->regmap);
> >> + regulator_bulk_disable(DA7213_NUM_SUPPLIES, da7213->supplies);
> >
> > There is no error checking.
> > We need to add error checking or return an error code.
>
> This is just a move of da7213_runtime_suspend() to be able to use it in
> da7213_suspend() w/o forward declaration.
As this is just code move, I went ahead and applied the series.
Best regards,
Pavel
--
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2025-11-25 12:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 10:51 [PATCH 5.10.y-cip 0/2] ASoC: Renesas: Backport audio fixes Claudiu
2025-11-22 10:51 ` [PATCH 5.10.y-cip 1/2] ASoC: da7213: Use component driver suspend/resume Claudiu
2025-11-24 0:16 ` [cip-dev] " Nobuhiro Iwamatsu (Toshiba)
2025-11-24 8:10 ` Claudiu Beznea
2025-11-24 10:15 ` Pavel Machek
2025-11-25 12:43 ` Pavel Machek [this message]
2025-11-22 10:51 ` [PATCH 5.10.y-cip 2/2] ASoC: renesas: rz-ssi: Use proper dma_buffer_pos after resume Claudiu
2025-11-24 10:21 ` Pavel Machek
2025-11-24 13:23 ` Claudiu Beznea
2025-11-24 13:28 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSWkcdhsz1ldyWqw@duo.ucw.cz \
--to=pavel@denx.de \
--cc=cip-dev@lists.cip-project.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=iwamatsu@gmail.com \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox