Re: [PATCH 5.10.y-cip 00/22] RZ/{G2L, G2LC, G2UL, G3S, Five, V2L}: Backport MSTOP support

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

Hi!

> Series backports the MSTOP (Module Stop) support for the Renesas
> RZ/G2L, RZ/G2LC, RZ/G2UL, RZ/G3S, RZ/Five, RZ/V2L SoCs.
> 
> The purpose of MSTOP is to reduce power consumption by stopping
> unnecessary module's functions.
> 
> If any master accesses a module that has the clock stopped and the
> MSTOP bit set, a bus error will occur.
> 
> Due to this, to avoid CPU generating synchronous aborts, changes
> to PM domain specific code were needed. The changes backported in
> this series were adjusted to be executed only for the above
> mentioned Renesas SoCs.
> 
> Please share your thoughts on this approach.

Ok, so after IRC meeting, I went through the patches again, but I
guess I'll need some more help.

03/22] PM: domains: Add helper to check for PM domain detach on unbind

This one is not mainline, and is only non-mainline patch around,
correct?

 05/22] driver core: platform: Drop dev_pm_domain_detach() call
 06/22] mmc: sdio: Drop dev_pm_domain_detach() call
 07/22] spi: Drop dev_pm_domain_detach() call
 08/22] rpmsg: core: Drop dev_pm_domain_detach() call
 09/22] soundwire: bus: Drop dev_pm_domain_detach() call
 10/22] serdev: Drop dev_pm_domain_detach() call
 11/22] i2c: core: Drop dev_pm_domain_detach() call

These are good cleanups, but are they neccessary for your goals? (Are
you using rpmsg?) Could we get rid of some or all of these?

22/22] clk: renesas: r9a07g04[34]: Use tabs instead of spaces

This one is certainly not neccessary.

Thanks and best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]