RE: [PATCH 6.12.y-cip 25/38] pinctrl: renesas: Add support for RZ/T2H

Prabhakar Mahadev Lad
2025-12-12T18:10:36Z

Hi Pavel,

Thank you for the review.

> Subject: Re: [PATCH 6.12.y-cip 25/38] pinctrl: renesas: Add support for
> RZ/T2H
>
> Hi!
>
> > From: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
> >
> > commit 34d4d093077a5c60d452a2f42d0c1a08e55b8614 upstream.
> >
> > Add a pin control and GPIO driver for the Renesas RZ/T2H (R9A09G077)
> > SoC.
>
>
> > +static int rzt2h_gpio_register(struct rzt2h_pinctrl *pctrl) {
> ...> + ret = devm_gpiochip_add_data(dev, chip, pctrl);
> > + if (ret)
> > + return dev_err_probe(dev, ret, "gpiochip registration
> failed\n");
> > +
> > + return ret;
> > +}
>
> This is strange way of saying "return 0".
>
Agreed, I will fix it in upstream if there is a change in this code path.

Cheers,
Prabhakar