Re: [cip-dev] [PATCH 6.12.y-cip 4/5] arm64: dts: renesas: r9a09g047e57-smarc: Add gpio keys

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Hi!

> > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > [ Upstram commit 9e95446b0cf93a91bc3b3b64c6d423f4024a6ff0 ]
> > >
> > > RZ/G3E SMARC EVK  has 3 user buttons called USER_SW1, USER_SW2 and
> > > USER_SW3 and SLEEP button with NMI support. Add a DT node in device
> > > tree to instantiate the gpio-keys driver for these buttons.
> > >
> > > The system can enter into STR state by pressing the sleep button and
> > > wakeup from STR is done by pressing power button. The USER_SW{1,2,3}
> > > configured as wakeup-source, so it can wakeup the system during s2idle.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Link:
> > > https://lore.kernel.org/20250702092755.70847-1-biju.das.jz@bp.renesas.
> > > com
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > [Biju: Squashed the commit 3e5df910b592d4 ("arm64: dts: renesas:
> > > r9a09g047e57-smarc: Fix gpio key's pin control node"]
> > 
> > Why did you need to squash the commit?
> 
> Previously Pavel mentioned to squash fixes patches like this
> So that cip-kenel have clean functional patch.

I'm not sure if I would request the squash here; I guess both options
would be okay here.

Best regards,
								Pavel

-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]