Re: [PATCH 6.12.y-cip 4/5] arm64: dts: renesas: r9a09g047e57-smarc: Add gpio keys

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

Hi!

> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> [ Upstram commit 9e95446b0cf93a91bc3b3b64c6d423f4024a6ff0 ]
> 
> RZ/G3E SMARC EVK  has 3 user buttons called USER_SW1, USER_SW2 and
> USER_SW3 and SLEEP button with NMI support. Add a DT node in device tree
> to instantiate the gpio-keys driver for these buttons.
> 
> The system can enter into STR state by pressing the sleep button and
> wakeup from STR is done by pressing power button. The USER_SW{1,2,3}
> configured as wakeup-source, so it can wakeup the system during
> s2idle.


> +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> @@ -8,6 +8,7 @@
>  /dts-v1/;
>  
>  /* Switch selection settings */
> +#define SW_LCD_EN		0
>  #define SW_GPIO8_CAN0_STB	0
>  #define SW_GPIO9_CAN1_STB	0
>  #define SW_LCD_EN		0

SW_LCD_EN already exists, 3 lines below. This may confuse someone when
the defines get out of sync.

> +	keys: keys {
> +		compatible = "gpio-keys";
> +
> +		key-1 {
> +			interrupts-extended = <&pinctrl KEY_1_GPIO IRQ_TYPE_EDGE_FALLING>;
> +			linux,code = <KEY_1>;
> +			label = "USER_SW1";
> +			wakeup-source;
> +			debounce-interval = <20>;
> +		};

Are they buttons (they return to 0 when force is released) or switches
(you move them to 1 position, then you have to move them again into 0
position)?

If they are buttons, label is quite confusing. If they are switches,
more fixing may be needed.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]