From: Pavel Machek <pavel@nabladev.com>
To: prabhakar.mahadev-lad.rj@bp.renesas.com
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH 6.12.y-cip 05/17] watchdog: rzv2h: Add support for RZ/T2H
Date: Mon, 5 Jan 2026 12:33:43 +0100 [thread overview]
Message-ID: <aVuhl9TJVs6rlwNT@duo.ucw.cz> (raw)
In-Reply-To: <20251231170026.17006-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
Hi!
Minor nit below:
> --- a/drivers/watchdog/rzv2h_wdt.c
> +++ b/drivers/watchdog/rzv2h_wdt.c
> +static int rzt2h_wdt_wdtdcr_init(struct platform_device *pdev,
> + struct rzv2h_wdt_priv *priv)
> +{
> + int ret;
> +
> + priv->wdtdcr = devm_platform_ioremap_resource(pdev, 1);
> + if (IS_ERR(priv->wdtdcr))
> + return PTR_ERR(priv->wdtdcr);
> +
> + ret = pm_runtime_resume_and_get(&pdev->dev);
> + if (ret)
> + return ret;
> +
> + rzt2h_wdt_wdtdcr_count_stop(priv);
> +
> + ret = pm_runtime_put(&pdev->dev);
> + if (ret < 0)
> + return ret;
> +
> + return 0;
> +}
I believe this can be simply "return pm_runtime_put()".
Best regards,
Pavel
--
In cooperation with Nabla.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-01-05 11:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 17:00 [PATCH 6.12.y-cip 00/17] Add SDHI/eMMC and WDT support for RZ/T2H and RZ/N2H Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 01/17] dt-bindings: watchdog: renesas,wdt: Add " Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 02/17] watchdog: rzv2h: Obtain clock-divider and timeout values from OF match data Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 03/17] watchdog: rzv2h: Make "oscclk" and reset controller optional Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 04/17] watchdog: rzv2h: Add support for configurable count clock source Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 05/17] watchdog: rzv2h: Add support for RZ/T2H Lad Prabhakar
2026-01-05 11:33 ` Pavel Machek [this message]
2026-01-05 13:40 ` [cip-dev] " Prabhakar Mahadev Lad
2026-01-07 13:44 ` Pavel Machek
2025-12-31 17:00 ` [PATCH 6.12.y-cip 06/17] dt-bindings: mmc: renesas,sdhi: Document RZ/T2H and RZ/N2H support Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 07/17] dt-bindings: clock: renesas,r9a09g077/87: Add SDHI_CLKHS clock ID Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 08/17] clk: renesas: cpg-mssr: Add read-back and delay handling for RZ/T2H MSTP Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 09/17] clk: renesas: r9a09g077: Add PLL2 and SDHI clock support Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 10/17] arm64: dts: renesas: r9a09g077: Add SDHI nodes Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 11/17] arm64: dts: renesas: r9a09g087: " Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 12/17] arm64: dts: renesas: rzt2h-rzn2h-evk: Enable eMMC Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 13/17] arm64: dts: renesas: rzt2h-rzn2h-evk: Enable MicroSD card slot Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 14/17] arm64: dts: renesas: rzt2h-rzn2h-evk: Enable SD " Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 15/17] arm64: dts: renesas: r9a09g077: Add WDT nodes Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 16/17] arm64: dts: renesas: r9a09g087: " Lad Prabhakar
2025-12-31 17:00 ` [PATCH 6.12.y-cip 17/17] arm64: dts: renesas: rzt2h-n2h-evk-common: Enable WDT2 Lad Prabhakar
2026-01-05 11:34 ` [cip-dev] [PATCH 6.12.y-cip 00/17] Add SDHI/eMMC and WDT support for RZ/T2H and RZ/N2H Pavel Machek
2026-01-06 19:45 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVuhl9TJVs6rlwNT@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox