Re: [cip-dev] [PATCH 6.1.y-cip 20/22] hwmon: (tmp108) Add support for I3C device

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

Hi!

> From: Frank Li <Frank.Li@nxp.com>
> 
> commit c40655e3310649866c4ebf7a10f0d53802ebdfa9 upstream.
> 
> Add support for I3C device in the tmp108 driver to handle the P3T1085
> sensor. Register the I3C device driver to enable I3C functionality for the
> sensor.
> 
...

> +++ b/drivers/hwmon/Kconfig
> @@ -2061,6 +2061,7 @@ config SENSORS_TMP108
>  	tristate "Texas Instruments TMP108"
>  	depends on I2C
>  	select REGMAP_I2C
> +	select REGMAP_I3C if I3C
>  	help
>  	  If you say yes here you get support for Texas Instruments TMP108
>  	  sensor chips and NXP P3T1085.

Ok, so config says "enable this for P3T1085 support", and we allow
user to enable this without I3C.

> +++ b/drivers/hwmon/tmp108.c
> @@ -440,7 +441,39 @@ static struct i2c_driver tmp108_driver = {

> +static int p3t1085_i3c_probe(struct i3c_device *i3cdev)
> +{
> +	struct device *dev = i3cdev_to_dev(i3cdev);
> +	struct regmap *regmap;
> +
> +#ifdef CONFIG_REGMAP_I3C
> +	regmap = devm_regmap_init_i3c(i3cdev, &tmp108_regmap_config);
> +#else
> +	regmap = ERR_PTR(-ENODEV);
> +#endif
> +
> +	if (IS_ERR(regmap))
> +		return dev_err_probe(dev, PTR_ERR(regmap),
> +				     "Failed to register i3c regmap\n");
> +

And then we fail the probe with "Failed to register i3c regmap"
message. That looks quite confusing to me.

Best regards,
								Pavel

-- 
In cooperation with Nabla.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]