Re: [PATCH 6.1.y-cip 07/11] thermal/drivers/renesas/rzg3e: Fix add thermal driver for the Renesas RZ/G3E SoC

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]

Hi!

> From: John Madieu <john.madieu.xa@bp.renesas.com>
> 
> commit dc67521c20b701b5237ff486ae078829dc1f8fea upstream.
> 
> When applied the change commit 19d3a401a617, a conflict appeared
> resulting into a manual fix. However the new file rzg3e_thermal.c was
> not added but stayed locally in source tree and miss to be merged with
> the entire change.
> 
> Fix this by adding the file back.

Ok, so you know you made a mistake, but for -cip, it would be
better to put this before the 6/ patch. You can't undo the mistake for
mainline, but ou can do that for -cip :-).

> Fixes: 19d3a401a617 ("Add thermal driver for the Renesas RZ/G3E SoC")

>  - used devm_reset_control_get_exclusive() + reset_control_deassert() +
>    devm_add_action_or_reset() instead of
>    devm_reset_control_get_exclusive_deasserted() as the latter is not
>    available in v6.1 CIP; added rzg3e_thermal_reset_assert() action
>    function for this

Yep so... this seems to be repeat issue in Renesas patches. Are we
going to hit it again in future? If so, maybe we should introduce
devm_reset_control_get_exclusive_deasserted() to 6.1, too.

> +	/* Convert to temperature */
> +	*temp = rzg3e_thermal_code_to_temp(priv, code);
> +
> +	dev_dbg(priv->dev, "temp=%d mC (%d.%03d°C), code=0x%03x\n",
> +		*temp, *temp / 1000, abs(*temp) % 1000, code);
> +

I'd expect dmesg output to be ASCII, not unicode, as it goes over
various serial lines etc. So maybe °C -> degC or just C.

Thanks and best regards,
								Pavel
-- 
In cooperation with Nabla.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]