Re: [cip-dev] [PATCH 5.10.y-cip] i2c: riic: Move suspend handling to NOIRQ phase

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Hi!

> Wake up the controller in the suspend() callback while runtime PM is
> still enabled. The I2C controller will remain available until the
> suspend_noirq() callback (pm_runtime_force_suspend()) is called. During
> resume, the I2C controller can be restored by the resume_noirq() callback
> (pm_runtime_force_resume()). Finally, the resume() callback re-enables
> autosuspend. As a result, the I2C controller can remain available until
> the system enters suspend_noirq() and from resume_noirq().

> +++ b/drivers/i2c/busses/i2c-riic.c
> @@ -606,6 +634,10 @@ static int riic_i2c_resume(struct device *dev)
>  	if (ret)
>  		return ret;
>  
> +	ret = pm_runtime_force_resume(dev);
> +	if (ret)
> +		return ret;
> +
>  	ret = riic_init_hw(riic);
>  	if (ret) {
>  		/*

Similar to the next error return, this likely should do
"reset_control_assert(riic->rstc);" before returning. I guess fixed
patch would be best here.

Thanks and best regards,
							Pavel
-- 
In cooperation with Nabla.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]