Re: [PATCH 6.12.y-cip 6/6] can: rcar_canfd: Add support for FD-Only mode

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

Hi!
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> [ Upstream commit 9a2b56a48c219d189366dd9bf4c2b42afde2f361 ]
> 
> The RZ/{G2L,G3E} and R-Car Gen4 SoCs support additional CAN FD mode called
> FD-only mode. In this mode, communication in Classical CAN frame format is
> disabled.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Link: https://patch.msgid.link/20251126155911.320563-3-biju.das.jz@bp.renesas.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/net/can/rcar/rcar_canfd.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
> index 68e6c7ac6649..4bfc7b5ac0ae 100644
> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -829,12 +830,20 @@ static int rcar_canfd_reset_controller(struct rcar_canfd_global *gpriv)
>  							 RCANFD_GEN4_FDCFG_FDOE);
>  				rcar_canfd_set_bit_reg(&gpriv->fcbase[ch].cfdcfg,
>  						       RCANFD_GEN4_FDCFG_CLOE);
> +			} else if (gpriv->fd_only_mode) {
> +				rcar_canfd_clear_bit_reg(&gpriv->fcbase[ch].cfdcfg,
> +							 RCANFD_GEN4_FDCFG_CLOE);
> +				rcar_canfd_set_bit_reg(&gpriv->fcbase[ch].cfdcfg,
> +						       RCANFD_GEN4_FDCFG_FDOE);
>  			} else {
>  				rcar_canfd_clear_bit_reg(&gpriv->fcbase[ch].cfdcfg,
>  							 RCANFD_GEN4_FDCFG_FDOE);
>  				rcar_canfd_clear_bit_reg(&gpriv->fcbase[ch].cfdcfg,
>  							 RCANFD_GEN4_FDCFG_CLOE);
>  			}
> +		} else if (gpriv->fd_only_mode) {
> +			rcar_canfd_set_bit_reg(&gpriv->fcbase[ch].cfdcfg,
> +					       RCANFD_GEN4_FDCFG_FDOE);
>  		}
>  	}
>

For the record, this part is way too confusing. Long term, it really
needs to go to separate functions... and be refactored.

Best regards,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]