From: Pavel Machek <pavel@nabladev.com>
To: Biju <biju.das.au@gmail.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>,
Pavel Machek <pavel@nabladev.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 6.12.y-cip v2 24/27] serial: sh-sci: Add support for RZ/G3E RSCI
Date: Fri, 13 Mar 2026 11:39:33 +0100 [thread overview]
Message-ID: <abPpZULsXhRmXTX9@duo.ucw.cz> (raw)
In-Reply-To: <20260311100458.162447-25-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
Hi!
> Add support for RZ/G3E RSCI. RSCI IP found on the RZ/G3E SoC is similar
> to RZ/T2H, but it has a 32-stage FIFO. It has 6 clocks(5 module clocks
> + 1 external clock) instead of 3 clocks(2 module clocks + 1 external
> clock) on T2H, has 6 irqs compared to 4 on RZ/T2H and has multiple resets.
> Add support for the hardware flow control.
> + baud = uart_get_baud_rate(port, termios, old, 0, max_freq);
> + if (!baud)
> + goto done;
> +
> + /* Divided Functional Clock using standard Bit Rate Register */
> + err = sci_scbrr_calc(s, baud, &brr1, &srr1, &cks1);
> + if (abs(err) < abs(min_err)) {
> + best_clk = SCI_FCK;
> + ccr0_val = 0;
> + min_err = err;
> + brr = brr1;
> + cks = cks1;
> + }
> +
> +done:
> + if (best_clk >= 0)
I'm not sure if "done" is best label here, and probably avoiding the
goto would be best.
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-03-13 10:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 10:04 [PATCH 6.12.y-cip v2 00/27] Add RZ/G3E RSCI support Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 01/27] dt-bindings: serial: rsci: Drop "uart-has-rtscts: false" Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 02/27] dt-bindings: serial: renesas,rsci: Document RZ/G3E support Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 03/27] clk: renesas: r9a09g047: Add RSCI clocks/resets Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 04/27] serial: sh-sci: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 05/27] tty: serial: sh-sci: fix RSCI FIFO overrun handling Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 06/27] serial: sh-sci: Sort include files alphabetically Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 07/27] serial: sh-sci: Merge sh-sci.h into sh-sci.c Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 08/27] serial: sh-sci: Fix deadlock during RSCI FIFO overrun error Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 09/27] serial: sh-sci: Update rx_trigger size for RZ/T2H RSCI Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 10/27] serial: rsci: Add set_rtrg() callback Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 11/27] serial: sh-sci: Drop checking port type for device file{create, remove} Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 12/27] serial: rsci: Drop rsci_clear_SCxSR() Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 13/27] serial: sh-sci: Drop extra lines Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 14/27] serial: rsci: Drop unused macro DCR Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 15/27] serial: rsci: Drop unused TDR register Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 16/27] serial: sh-sci: Use devm_reset_control_array_get_exclusive() Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 17/27] serial: sh-sci: Add sci_is_rsci_type() Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 18/27] serial: sh-sci: Rename port SCI_PORT_RSCI->RSCI_PORT_SCIF16 Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 19/27] serial: sh-sci: Add RSCI_PORT_SCIF32 port ID Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 20/27] serial: sh-sci: Add support for RZ/G3E RSCI clks Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 21/27] serial: sh-sci: Make sci_scbrr_calc() public Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 22/27] serial: sh-sci: Add finish_console_write() callback Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 23/27] serial: rsci: Rename early_console data, port_params and callback() names Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 24/27] serial: sh-sci: Add support for RZ/G3E RSCI Biju
2026-03-13 10:39 ` Pavel Machek [this message]
2026-03-13 13:22 ` Biju Das
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 25/27] arm64: dts: renesas: r9a09g047: Add RSCI nodes Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 26/27] arm64: dts: renesas: renesas-smarc2: Move aliases to board DTS Biju
2026-03-11 10:04 ` [PATCH 6.12.y-cip v2 27/27] arm64: dts: renesas: r9a09g047e57-smarc: Enable rsci{2,4,9} nodes Biju
2026-03-13 10:40 ` [PATCH 6.12.y-cip v2 00/27] Add RZ/G3E RSCI support Pavel Machek
2026-03-18 9:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abPpZULsXhRmXTX9@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox