Re: [PATCH 6.1.y-cip 2/7] drm: renesas: rz-du: Implement MIPI DSI host transfers

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Hi!

> commit 6f392f37165008cfb3f89d723aa019e372ee79b9 upstream.
> 
> Add support for sending MIPI DSI command packets from the host to a
> peripheral. This is required for panels that need configuration before
> they accept video data.

> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> +static ssize_t rzg2l_mipi_dsi_read_response(struct rzg2l_mipi_dsi *dsi,
> +					    const struct mipi_dsi_msg *msg)
> +{
> +	u8 *msg_rx = msg->rx_buf;
> +	u8 datatype;
> +	u32 result;
> +	u16 size;
> +
> +	result = rzg2l_mipi_dsi_link_read(dsi, RXRSS0R);
> +	if (result & RXRSS0R_RXPKTDFAIL) {
> +		dev_err(dsi->dev, "packet rx data did not save correctly\n");
> +		return -EPROTO;
> +	}
> +
> +	if (result & RXRSS0R_RXFAIL) {
> +		dev_err(dsi->dev, "packet rx failure\n");
> +		return -EPROTO;
> +	}
> +
> +	if (!(result & RXRSS0R_RXSUC))
> +		return -EPROTO;

This probably should do dev_err or dev_dbg before returning.

> @@ -1274,6 +1453,11 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		goto err_pm_disable;
> 
> +	dsi->dcs_buf_virt = dma_alloc_coherent(dsi->host.dev, RZG2L_DCS_BUF_SIZE,
> +					       &dsi->dcs_buf_phys, GFP_KERNEL);
> +	if (!dsi->dcs_buf_virt)
> +		return -ENOMEM;
> +
>  	return 0;
>

This probably should be { err = -ENOMEM; goto err_pm_disable; }

Thanks and best regards,
									Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]