public inbox for cip-dev@lists.cip-project.org
 help / color / mirror / Atom feed
From: Sai Sree Kartheek Adivi <s-adivi@ti.com>
To: Pavel Machek <pavel@nabladev.com>
Cc: <cip-dev@lists.cip-project.org>,
	<nobuhiro.iwamatsu.x90@mail.toshiba>,
	<chris.paterson2@renesas.com>, <vigneshr@ti.com>
Subject: Re: [PATCH 6.12.y-cip] dmaengine: ti: k3-udma: Enable second resource range for BCDMA and PKTDMA
Date: Wed, 28 Jan 2026 13:47:56 +0530	[thread overview]
Message-ID: <ae120bfd-6efb-4ab4-b0fe-0c8964a2fbd2@ti.com> (raw)
In-Reply-To: <aXicChQlaiaAq7w3@duo.ucw.cz>


On 27/01/26 16:35, Pavel Machek wrote:
> Hi!
>
> Patch looks good, even if I'd like less code duplication.
>
> But patch can't be applied as is: it is missing "upstream commit xxx"
> marking at [1] and your sign-off at [2].
>
> Plus, -stable might be better place for this patch. We currently don't
> have am62p specific patches in the tree, so this affects 6.12-stable,
> too, and should be fixed there AFAICT.

Thanks for the feedback. Posted on stable tree.
https://lore.kernel.org/all/20260127191105.1961020-1-s-adivi@ti.com/

- Kartheek

>
> Best regards,
> 								Pavel
>
>> From: Siddharth Vadapalli <s-vadapalli@ti.com>
> [1]
>
>> The SoC DMA resources for UDMA, BCDMA and PKTDMA can be described via a
>> combination of up to two resource ranges. The first resource range handles
>> the default partitioning wherein all resources belonging to that range are
>> allocated to a single entity and form a continuous range. For use-cases
>> where the resources are shared across multiple entities and require to be
>> described via discontinuous ranges, a second resource range is required.
>>
>> Currently, udma_setup_resources() supports handling resources that belong
>> to the second range. Extend bcdma_setup_resources() and
>> pktdma_setup_resources() to support the same.
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>> Link: https://lore.kernel.org/r/20250205121805.316792-1-s-vadapalli@ti.com
>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> [2]
>
>> ---
>>
>> Hi,
>>
>> This patch is upstreamed at [1]. This is required for ethernet to be
>> functional on TI AM62P SoC.
>>
>> Thanks,
>> Kartheek
>>
>> [1] v6.14-rc1-24-g566beb347ede
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/dma/ti/k3-udma.c?id=566beb347eded7a860511164a7a163bc882dc4d0
>>
>>   drivers/dma/ti/k3-udma.c | 36 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>
>> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
>> index 38b54719587c..e877cd50898b 100644
>> --- a/drivers/dma/ti/k3-udma.c
>> +++ b/drivers/dma/ti/k3-udma.c
>> @@ -4876,6 +4876,12 @@ static int bcdma_setup_resources(struct udma_dev *ud)
>>   				irq_res.desc[i].start = rm_res->desc[i].start +
>>   							oes->bcdma_bchan_ring;
>>   				irq_res.desc[i].num = rm_res->desc[i].num;
>> +
>> +				if (rm_res->desc[i].num_sec) {
>> +					irq_res.desc[i].start_sec = rm_res->desc[i].start_sec +
>> +									oes->bcdma_bchan_ring;
>> +					irq_res.desc[i].num_sec = rm_res->desc[i].num_sec;
>> +				}
>>   			}
>>   		}
>>   	} else {
>> @@ -4899,6 +4905,15 @@ static int bcdma_setup_resources(struct udma_dev *ud)
>>   				irq_res.desc[i + 1].start = rm_res->desc[j].start +
>>   							oes->bcdma_tchan_ring;
>>   				irq_res.desc[i + 1].num = rm_res->desc[j].num;
>> +
>> +				if (rm_res->desc[j].num_sec) {
>> +					irq_res.desc[i].start_sec = rm_res->desc[j].start_sec +
>> +									oes->bcdma_tchan_data;
>> +					irq_res.desc[i].num_sec = rm_res->desc[j].num_sec;
>> +					irq_res.desc[i + 1].start_sec = rm_res->desc[j].start_sec +
>> +									oes->bcdma_tchan_ring;
>> +					irq_res.desc[i + 1].num_sec = rm_res->desc[j].num_sec;
>> +				}
>>   			}
>>   		}
>>   	}
>> @@ -4919,6 +4934,15 @@ static int bcdma_setup_resources(struct udma_dev *ud)
>>   				irq_res.desc[i + 1].start = rm_res->desc[j].start +
>>   							oes->bcdma_rchan_ring;
>>   				irq_res.desc[i + 1].num = rm_res->desc[j].num;
>> +
>> +				if (rm_res->desc[j].num_sec) {
>> +					irq_res.desc[i].start_sec = rm_res->desc[j].start_sec +
>> +									oes->bcdma_rchan_data;
>> +					irq_res.desc[i].num_sec = rm_res->desc[j].num_sec;
>> +					irq_res.desc[i + 1].start_sec = rm_res->desc[j].start_sec +
>> +									oes->bcdma_rchan_ring;
>> +					irq_res.desc[i + 1].num_sec = rm_res->desc[j].num_sec;
>> +				}
>>   			}
>>   		}
>>   	}
>> @@ -5053,6 +5077,12 @@ static int pktdma_setup_resources(struct udma_dev *ud)
>>   			irq_res.desc[i].start = rm_res->desc[i].start +
>>   						oes->pktdma_tchan_flow;
>>   			irq_res.desc[i].num = rm_res->desc[i].num;
>> +
>> +			if (rm_res->desc[i].num_sec) {
>> +				irq_res.desc[i].start_sec = rm_res->desc[i].start_sec +
>> +								oes->pktdma_tchan_flow;
>> +				irq_res.desc[i].num_sec = rm_res->desc[i].num_sec;
>> +			}
>>   		}
>>   	}
>>   	rm_res = tisci_rm->rm_ranges[RM_RANGE_RFLOW];
>> @@ -5064,6 +5094,12 @@ static int pktdma_setup_resources(struct udma_dev *ud)
>>   			irq_res.desc[i].start = rm_res->desc[j].start +
>>   						oes->pktdma_rchan_flow;
>>   			irq_res.desc[i].num = rm_res->desc[j].num;
>> +
>> +			if (rm_res->desc[j].num_sec) {
>> +				irq_res.desc[i].start_sec = rm_res->desc[j].start_sec +
>> +								oes->pktdma_rchan_flow;
>> +				irq_res.desc[i].num_sec = rm_res->desc[j].num_sec;
>> +			}
>>   		}
>>   	}
>>   	ret = ti_sci_inta_msi_domain_alloc_irqs(ud->dev, &irq_res);


      reply	other threads:[~2026-01-28  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27  7:56 [PATCH 6.12.y-cip] dmaengine: ti: k3-udma: Enable second resource range for BCDMA and PKTDMA Sai Sree Kartheek Adivi
2026-01-27 11:05 ` Pavel Machek
2026-01-28  8:17   ` Sai Sree Kartheek Adivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae120bfd-6efb-4ab4-b0fe-0c8964a2fbd2@ti.com \
    --to=s-adivi@ti.com \
    --cc=chris.paterson2@renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro.iwamatsu.x90@mail.toshiba \
    --cc=pavel@nabladev.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox