RE: [PATCH 6.1.y-cip 2/7] drm: renesas: rz-du: Implement MIPI DSI host transfers

Chris Brandt
2026-04-14T11:33:21Z

Hi Pavel,

These patches are direct backports from mainline.
I am trying to keep the CIP version as close to the mainline version as possible.

> > + if (!(result & RXRSS0R_RXSUC))
> > + return -EPROTO;
>
> This probably should do dev_err or dev_dbg before returning.

Honestly, we are checking for this error, but I have never seen it actually happen in any system.
But, your point is valid because we are printing out messages for other errors.

> > + dsi->dcs_buf_virt = dma_alloc_coherent(dsi->host.dev, RZG2L_DCS_BUF_SIZE,
> > + &dsi->dcs_buf_phys, GFP_KERNEL);
> > + if (!dsi->dcs_buf_virt)
> > + return -ENOMEM;
> > +
> > return 0;
> >
>
> This probably should be { err = -ENOMEM; goto err_pm_disable; }

That is a good point.
I wrote that part of the driver for an older version of the kernel a couple years ago before they had those return options.
Then, someone else ported it to the mainline version of the driver and submitted it.
When I reviewed the mainline version, I didn't catch that.
I might push a fix to mainline with CC:stable.

Chris