Re: [PATCH 6.1.y-cip 14/23] hwmon: (lm75) Fix tmp112 default config

[Pavel Machek <pavel@nabladev.com>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

Hi!

> From: Abdel Alkuor <alkuor@gmail.com>
> 
> commit 8249a0e25dd2972e919a2552425bf4faa2581d24 upstream.
> 
> Set tmp112 conversion rate to 8 HZ and 12-bit mode.
> 
> Fixes: 35cd18048542 ("hwmon: (lm75) Aproximate sample times to data-sheet values")
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
> Link: https://lore.kernel.org/r/20240106030254.384963-1-alkuor@gmail.com
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> ---
>  drivers/hwmon/lm75.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index f6e16dfa11c5..5eba180b66a0 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -270,8 +270,9 @@ static const struct lm75_params device_params[] = {
>  		.resolutions = (u8 []) {9, 10, 11, 12 },
>  	},
>  	[tmp112] = {
> -		.set_mask = 3 << 5,	/* 8 samples / second */
> -		.clr_mask = 1 << 7,	/* no one-shot mode*/
> +		.config_reg_16bits = true,
> +		.set_mask = 0x60C0,	/* 12-bit mode, 8 samples / second */
> +		.clr_mask = 1 << 15,	/* no one-shot mode*/

I would not mind space before "*/". But not your code and not your
patch...

Best regards,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]