From: Pavel Machek <pavel@nabladev.com>
To: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
Cc: cip-dev@lists.cip-project.org, pavel@nabladev.com,
nobuhiro.iwamatsu.x90@mail.toshiba
Subject: Re: [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger
Date: Wed, 2 Sep 2026 19:00:02 +0200 [thread overview]
Message-ID: <aphWErnJi7t9RK-a@duo.ucw.cz> (raw)
In-Reply-To: <20260902092353.24648-9-ovidiu.panait.rb@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
Hi!
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> commit 7585a27644f338b3e764ceeda4be10e7047331a7 upstream.
>
> Handle the RZ/V2H ICU error interrupt to help diagnose latched bus,
> ECC RAM, and CA55/IP error conditions.
>
> Support error injection via ICU_SWPE to allow testing the pseudo error
> error interrupts.
>
> Account for SoC differences in ECC RAM error register coverage so the
> handler only iterates over valid ECC status/clear banks, and route the
> RZ/V2N compatible to a probe path with the correct ECC range while
> keeping the existing RZ/V2H and RZ/G3E handling.
>
> +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> + fwspec.param_count = 2;
> + fwspec.param[0] = ICU_ERR_INT_START;
> + fwspec.param[1] = IRQ_TYPE_LEVEL_HIGH;
> +
> + virq = irq_create_fwspec_mapping(&fwspec);
> + if (!virq) {
> + return dev_err_probe(dev, -EINVAL, "failed to create IRQ mapping for %s\n",
> + icu_err);
> + }
> +
> + ret = devm_request_irq(dev, virq, rzv2h_icu_error_irq, 0, dev_name(dev), rzv2h_icu_data);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to request %s IRQ\n", icu_err);
> +
> return 0;
It seems to me like the error path and possibly unload path need call
to irq_dispose_mapping()?
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-09-02 17:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 9:23 [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 01/11] irqchip/renesas-rzv2h: Fix error path in rzv2h_icu_probe_common() Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 02/11] irqchip/renesas-rzv2h: Use local node pointer Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 03/11] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Ovidiu Panait
2026-09-02 16:57 ` Pavel Machek
2026-09-02 9:23 ` [PATCH 6.1.y-cip 04/11] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 05/11] irqchip/renesas-rzv2h: Clarify IRQ range definitions and tighten TINT validation Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 06/11] irqchip/renesas-rzv2h: Replace single irq_chip with per-region irq_chip instances Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 07/11] irqchip/renesas-rzv2h: Add CA55 software interrupt support Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 08/11] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger Ovidiu Panait
2026-09-02 17:00 ` Pavel Machek [this message]
2026-09-02 9:23 ` [PATCH 6.1.y-cip 09/11] irqchip/renesas-rzv2h: Kill swint_idx[] Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 10/11] irqchip/renesas-rzv2h: Kill swint_names[] Ovidiu Panait
2026-09-02 9:23 ` [PATCH 6.1.y-cip 11/11] irqchip/renesas-rzv2h: Kill icu_err string Ovidiu Panait
2026-09-02 17:00 ` [PATCH 6.1.y-cip 00/11] Add ICU error and software interrupt support for RZ/V2H and RZ/V2N Pavel Machek
2026-09-03 19:33 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aphWErnJi7t9RK-a@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=ovidiu.panait.rb@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).