From: Pavel Machek <pavel@nabladev.com>
To: nobuhiro.iwamatsu.x90@mail.toshiba
Cc: cip-dev@lists.cip-project.org, pavel@nabladev.com, uli@fpond.eu,
tommaso.merciai.xr@bp.renesas.com,
fabrizio.castro.jz@renesas.com, claudiu.beznea.uj@bp.renesas.com,
cosmin-gabriel.tanislav.xa@renesas.com
Subject: Re: [cip-dev] [PATCH 6.1.y-cip 2/5] dmaengine: sh: rz-dmac: fix device leak on probe failure
Date: Mon, 26 Oct 2026 17:58:58 +0100 [thread overview]
Message-ID: <at-G0rpdQ3RHmZx0@duo.ucw.cz> (raw)
In-Reply-To: <1792979242-32127-3-git-send-email-nobuhiro.iwamatsu.x90@mail.toshiba>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
Hi!
> From: Johan Hovold <johan@kernel.org>
>
> commit 9fb490323997dcb6f749cd2660a17a39854600cd upstream.
>
> Make sure to drop the reference taken when looking up the ICU device
> during probe also on probe failures (e.g. probe deferral).
According to code, if "renesas,icu" is not present, that's still okay:
ret = of_parse_phandle_with_fixed_args(np, "renesas,icu", 1, 0, &args);
if (ret == -ENOENT)
return 0;
but we skip put_device() in such case. Original code did do
platform_device_put(NULL) in this case, so I guess we are still okay.
Reviewed-by: Pavel Machek <pavel@nabladev.com>
Best regards,
Pavel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2026-10-26 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 1:47 [PATCH 6.1.y-cip 0/5] Fix CVEs related to patches backported to the CIP kernel Nobuhiro Iwamatsu
2026-10-26 1:47 ` [PATCH 6.1.y-cip 1/5] i3c: master: renesas: Fix memory leak in renesas_i3c_i3c_xfers() Nobuhiro Iwamatsu
2026-10-26 10:45 ` [cip-dev] " claudiu beznea
2026-10-26 1:47 ` [PATCH 6.1.y-cip 2/5] dmaengine: sh: rz-dmac: fix device leak on probe failure Nobuhiro Iwamatsu
2026-10-26 10:48 ` [cip-dev] " claudiu beznea
2026-10-26 16:58 ` Pavel Machek [this message]
2026-10-26 1:47 ` [PATCH 6.1.y-cip 3/5] iio: adc: rzg2l_adc: Set driver data before enabling runtime PM Nobuhiro Iwamatsu
2026-10-26 10:49 ` [cip-dev] " claudiu beznea
2026-10-26 1:47 ` [PATCH 6.1.y-cip 4/5] counter: rz-mtu3-cnt: prevent counter from being toggled multiple times Nobuhiro Iwamatsu
2026-10-26 1:47 ` [PATCH 6.1.y-cip 5/5] counter: rz-mtu3-cnt: do not use struct rz_mtu3_channel's dev member Nobuhiro Iwamatsu
2026-10-26 17:05 ` [cip-dev] [PATCH 6.1.y-cip 0/5] Fix CVEs related to patches backported to the CIP kernel Pavel Machek
2026-10-27 21:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at-G0rpdQ3RHmZx0@duo.ucw.cz \
--to=pavel@nabladev.com \
--cc=cip-dev@lists.cip-project.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox