CIP-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@nabladev.com>
To: nobuhiro.iwamatsu.x90@mail.toshiba, uli@fpond.eu
Cc: prabhakar.mahadev-lad.rj@bp.renesas.com,
	cip-dev@lists.cip-project.org, pavel@nabladev.com, uli@fpond.eu,
	biju.das.jz@bp.renesas.com
Subject: Re: [cip-dev] [PATCH 4.19.y-cip] mmc: renesas_sdhi: abort tuning when timeout detected
Date: Mon, 9 Nov 2026 10:51:52 +0100	[thread overview]
Message-ID: <avGXuLpdFa9CzeeK@duo.ucw.cz> (raw)
In-Reply-To: <TY7PR01MB148182531E8307BD3B1211C01CD732@TY7PR01MB14818.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

Hi!

> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > commit 2c9017d0b5d3fbf17e69577a42d9e610ca122810 upstream.
> > 
> > We have to bring the eMMC from sending-data state back to transfer state once
> > we detected a CRC error (timeout) during tuning. So, send a stop command via
> > mmc_abort_tuning().
> > 
> > Fixes: 4f11997773b6 ("mmc: tmio: Add tuning support") Reported-by Yoshihiro
> > Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Link:
> > https://lore.kernel.org/r/20210602073435.5955-1-wsa+renesas@sang-engine
> > ering.com
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > [PL: manually applied the changes]
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> I reviewed this series, looks good to me.
> 
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Patch looks okay to me, too. Adding Ulrich to the cc.

Reviewed-by: Pavel Machek <pavel@nabladev.com>

Best regards,
								Pavel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2026-11-09  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 12:14 [PATCH 4.19.y-cip] mmc: renesas_sdhi: abort tuning when timeout detected Lad Prabhakar
2026-11-09  2:22 ` nobuhiro.iwamatsu.x90
2026-11-09  9:51   ` Pavel Machek [this message]
2026-11-09 16:49     ` [cip-dev] " Ulrich Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avGXuLpdFa9CzeeK@duo.ucw.cz \
    --to=pavel@nabladev.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro.iwamatsu.x90@mail.toshiba \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=uli@fpond.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox