Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

[Jan Kiszka]

On 27.06.22 09:12, Sarath P T wrote:
> From: sarath P T <Sarath_PT@mentor.com>
> 
> When we launch the start-efishell.sh script for
> adding the keys into OVMF firmware we faced
> gtk initialization failed error. So it seems
> we need to open the OVMF in nographic mode, hence
> we added the required option to the script.
> 

Which QEMU-Version? Which OVMF version (buster/bullseye/something else)?
I'm not seeing this, but I'm facing other issues with that firmware
provided by bullseye (a crash).

> Signed-off-by: sarath P T <Sarath_PT@mentor.com>
> ---
>  scripts/start-efishell.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
> index d451f43..0831f83 100755
> --- a/scripts/start-efishell.sh
> +++ b/scripts/start-efishell.sh
> @@ -2,7 +2,7 @@
>  ovmf_code=${OVMF_CODE:-/usr/share/OVMF/OVMF_CODE.secboot.fd}
>  ovmf_vars=${OVMF_VARS:-./OVMF_VARS.fd}
>  DISK=$1
> -qemu-system-x86_64 -enable-kvm -M q35 \
> +qemu-system-x86_64 -enable-kvm -M q35 -nographic \
>                     -cpu host,hv_relaxed,hv_vapic,hv-spinlocks=0xfff -smp 2 -m 2G -no-hpet \
>                     -global ICH9-LPC.disable_s3=1 \
>                     -global isa-fdc.driveA= \
Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

[Gylstorff Quirin]

On 6/27/22 10:14, Jan Kiszka via lists.cip-project.org wrote:
> On 27.06.22 09:12, Sarath P T wrote:
>> From: sarath P T <Sarath_PT@mentor.com>
>>
>> When we launch the start-efishell.sh script for
>> adding the keys into OVMF firmware we faced
>> gtk initialization failed error. So it seems
>> we need to open the OVMF in nographic mode, hence
>> we added the required option to the script.
>>
> 
> Which QEMU-Version? Which OVMF version (buster/bullseye/something else)?
> I'm not seeing this, but I'm facing other issues with that firmware
> provided by bullseye (a crash).
>  >> Signed-off-by: sarath P T <Sarath_PT@mentor.com>
>> ---
>>   scripts/start-efishell.sh | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
>> index d451f43..0831f83 100755
>> --- a/scripts/start-efishell.sh
>> +++ b/scripts/start-efishell.sh
>> @@ -2,7 +2,7 @@
>>   ovmf_code=${OVMF_CODE:-/usr/share/OVMF/OVMF_CODE.secboot.fd}

This should be changed to the 4M version.

@jan
The 4M version does also trigger a crash?

Quirin

>>   ovmf_vars=${OVMF_VARS:-./OVMF_VARS.fd}
>>   DISK=$1
>> -qemu-system-x86_64 -enable-kvm -M q35 \
>> +qemu-system-x86_64 -enable-kvm -M q35 -nographic \
>>                      -cpu host,hv_relaxed,hv_vapic,hv-spinlocks=0xfff -smp 2 -m 2G -no-hpet \
>>                      -global ICH9-LPC.disable_s3=1 \
>>                      -global isa-fdc.driveA= \
> Jan
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8599): https://lists.cip-project.org/g/cip-dev/message/8599
> Mute This Topic: https://lists.cip-project.org/mt/92016246/1753640
> Group Owner: cip-dev+owner@lists.cip-project.org
> Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129121/1753640/1405269326/xyzzy [quirin.gylstorff@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

[Jan Kiszka]

On 27.06.22 10:23, Gylstorff Quirin wrote:
> 
> 
> On 6/27/22 10:14, Jan Kiszka via lists.cip-project.org wrote:
>> On 27.06.22 09:12, Sarath P T wrote:
>>> From: sarath P T <Sarath_PT@mentor.com>
>>>
>>> When we launch the start-efishell.sh script for
>>> adding the keys into OVMF firmware we faced
>>> gtk initialization failed error. So it seems
>>> we need to open the OVMF in nographic mode, hence
>>> we added the required option to the script.
>>>
>>
>> Which QEMU-Version? Which OVMF version (buster/bullseye/something else)?
>> I'm not seeing this, but I'm facing other issues with that firmware
>> provided by bullseye (a crash).
>>  >> Signed-off-by: sarath P T <Sarath_PT@mentor.com>
>>> ---
>>>   scripts/start-efishell.sh | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
>>> index d451f43..0831f83 100755
>>> --- a/scripts/start-efishell.sh
>>> +++ b/scripts/start-efishell.sh
>>> @@ -2,7 +2,7 @@
>>>   ovmf_code=${OVMF_CODE:-/usr/share/OVMF/OVMF_CODE.secboot.fd}
> 
> This should be changed to the 4M version.
> 
> @jan
> The 4M version does also trigger a crash?
> 

Yes, it does.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

RE: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

[Kanagarajan, Vijaikumar]

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On
> Behalf Of Jan Kiszka
> Sent: 27 June 2022 18:22
> To: Gylstorff Quirin <quirin.gylstorff@siemens.com>; cip-dev@lists.cip-
> project.org; P T, Sarath <Sarath_PT@mentor.com>
> Subject: Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -
> nographic option
> 
> On 27.06.22 10:23, Gylstorff Quirin wrote:
> >
> >
> > On 6/27/22 10:14, Jan Kiszka via lists.cip-project.org wrote:
> >> On 27.06.22 09:12, Sarath P T wrote:
> >>> From: sarath P T <Sarath_PT@mentor.com>
> >>>
> >>> When we launch the start-efishell.sh script for adding the keys into
> >>> OVMF firmware we faced gtk initialization failed error. So it seems
> >>> we need to open the OVMF in nographic mode, hence we added the
> >>> required option to the script.
> >>>
> >>
> >> Which QEMU-Version? Which OVMF version (buster/bullseye/something
> else)?
> >> I'm not seeing this, but I'm facing other issues with that firmware
> >> provided by bullseye (a crash).
> >>  >> Signed-off-by: sarath P T <Sarath_PT@mentor.com>
> >>> ---
> >>>   scripts/start-efishell.sh | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
> >>> index d451f43..0831f83 100755
> >>> --- a/scripts/start-efishell.sh
> >>> +++ b/scripts/start-efishell.sh
> >>> @@ -2,7 +2,7 @@
> >>>   ovmf_code=${OVMF_CODE:-
> /usr/share/OVMF/OVMF_CODE.secboot.fd}
> >
> > This should be changed to the 4M version.
> >
> > @jan
> > The 4M version does also trigger a crash?
> >
> 
> Yes, it does.

We have not seen such errors. If you share the setup details (Qemu version/host distro/OVMF version) we can give it a try.

Thanks,
Vijai Kumar K

> 
> Jan
> 
> --
> Siemens AG, Technology
> Competence Center Embedded Linux

Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

[Jan Kiszka]

On 27.06.22 14:57, Kanagarajan, Vijaikumar wrote:
> 
> 
>> -----Original Message-----
>> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On
>> Behalf Of Jan Kiszka
>> Sent: 27 June 2022 18:22
>> To: Gylstorff Quirin <quirin.gylstorff@siemens.com>; cip-dev@lists.cip-
>> project.org; P T, Sarath <Sarath_PT@mentor.com>
>> Subject: Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -
>> nographic option
>>
>> On 27.06.22 10:23, Gylstorff Quirin wrote:
>>>
>>>
>>> On 6/27/22 10:14, Jan Kiszka via lists.cip-project.org wrote:
>>>> On 27.06.22 09:12, Sarath P T wrote:
>>>>> From: sarath P T <Sarath_PT@mentor.com>
>>>>>
>>>>> When we launch the start-efishell.sh script for adding the keys into
>>>>> OVMF firmware we faced gtk initialization failed error. So it seems
>>>>> we need to open the OVMF in nographic mode, hence we added the
>>>>> required option to the script.
>>>>>
>>>>
>>>> Which QEMU-Version? Which OVMF version (buster/bullseye/something
>> else)?
>>>> I'm not seeing this, but I'm facing other issues with that firmware
>>>> provided by bullseye (a crash).
>>>>  >> Signed-off-by: sarath P T <Sarath_PT@mentor.com>
>>>>> ---
>>>>>   scripts/start-efishell.sh | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
>>>>> index d451f43..0831f83 100755
>>>>> --- a/scripts/start-efishell.sh
>>>>> +++ b/scripts/start-efishell.sh
>>>>> @@ -2,7 +2,7 @@
>>>>>   ovmf_code=${OVMF_CODE:-
>> /usr/share/OVMF/OVMF_CODE.secboot.fd}
>>>
>>> This should be changed to the 4M version.
>>>
>>> @jan
>>> The 4M version does also trigger a crash?
>>>
>>
>> Yes, it does.
> 
> We have not seen such errors. If you share the setup details (Qemu version/host distro/OVMF version) we can give it a try.
> 

Resolved - my OVMF_VARS file was broken, and that was simply causing a
crash. Doesn't leave a good feeling about EDK2 now...

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

RE: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -nographic option

[Kanagarajan, Vijaikumar]

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On
> Behalf Of Jan Kiszka
> Sent: 27 June 2022 13:44
> To: P T, Sarath <Sarath_PT@mentor.com>; cip-dev@lists.cip-project.org
> Subject: Re: [cip-dev] [isar-cip-core] [PATCH] scripts/start-efishell.sh: Add -
> nographic option
> 
> On 27.06.22 09:12, Sarath P T wrote:
> > From: sarath P T <Sarath_PT@mentor.com>
> >
> > When we launch the start-efishell.sh script for adding the keys into
> > OVMF firmware we faced gtk initialization failed error. So it seems we
> > need to open the OVMF in nographic mode, hence we added the required
> > option to the script.
> >
> 
> Which QEMU-Version? Which OVMF version (buster/bullseye/something
> else)?
> I'm not seeing this, but I'm facing other issues with that firmware provided by
> bullseye (a crash).

Nope. Not related to OVMF crashes. This is just to make the script work on headless systems/over ssh.

Sarath, 
Can you send a V2 with a modified commit message. The latter half is a bit misleading. Probably you meant
"open QEMU" and not OVMF.

Thanks,
Vijai Kumar K


> 
> > Signed-off-by: sarath P T <Sarath_PT@mentor.com>
> > ---
> >  scripts/start-efishell.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/start-efishell.sh b/scripts/start-efishell.sh
> > index d451f43..0831f83 100755
> > --- a/scripts/start-efishell.sh
> > +++ b/scripts/start-efishell.sh
> > @@ -2,7 +2,7 @@
> >  ovmf_code=${OVMF_CODE:-/usr/share/OVMF/OVMF_CODE.secboot.fd}
> >  ovmf_vars=${OVMF_VARS:-./OVMF_VARS.fd}
> >  DISK=$1
> > -qemu-system-x86_64 -enable-kvm -M q35 \
> > +qemu-system-x86_64 -enable-kvm -M q35 -nographic \
> >                     -cpu host,hv_relaxed,hv_vapic,hv-spinlocks=0xfff -smp 2 -m 2G -
> no-hpet \
> >                     -global ICH9-LPC.disable_s3=1 \
> >                     -global isa-fdc.driveA= \
> Jan
> 
> --
> Siemens AG, Technology
> Competence Center Embedded Linux