From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Wed, 23 Nov 2011 11:15:28 +0100 Subject: [Cluster-devel] [PATCH 09/41] cman_tool: prevent buffer overrun In-Reply-To: <1322043360-17037-1-git-send-email-fdinitto@redhat.com> References: <1322043360-17037-1-git-send-email-fdinitto@redhat.com> Message-ID: <013e98d0543e750e5c59b3efa4ab16b759bee8aa.1322043045.git.fdinitto@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 6d8a1eb... 5a5aa7b... M cman/cman_tool/main.c cman/cman_tool/main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cman/cman_tool/main.c b/cman/cman_tool/main.c index 6d8a1eb..5a5aa7b 100644 --- a/cman/cman_tool/main.c +++ b/cman/cman_tool/main.c @@ -641,7 +641,7 @@ static void set_votes(commandline_t *comline) else { /* Resolve node name into a number */ node.cn_nodeid = 0; - strcpy(node.cn_name, comline->nodenames[0]); + strncpy(node.cn_name, comline->nodenames[0], CMAN_MAX_NODENAME_LEN); if (cman_get_node(h, node.cn_nodeid, &node)) die("Can't set votes for node %s : %s\n", node.cn_name, strerror(errno)); nodeid = node.cn_nodeid; @@ -864,7 +864,7 @@ static void kill_node(commandline_t *comline) /* Resolve node name into a number */ node.cn_nodeid = 0; - strcpy(node.cn_name, comline->nodenames[i]); + strncpy(node.cn_name, comline->nodenames[i], CMAN_MAX_NODENAME_LEN); if (cman_get_node(h, node.cn_nodeid, &node)) { fprintf(stderr, "Can't kill node %s : %s\n", node.cn_name, strerror(errno)); continue; -- 1.7.4.4