From: Ross Lagerwall <ross.lagerwall@citrix.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH V2] gfs2: clean_journal was setting sd_log_flush_head replaying other journals
Date: Thu, 28 Mar 2019 11:58:03 +0000 [thread overview]
Message-ID: <018cefb1-85c6-36cd-9154-f8e9729d3db7@citrix.com> (raw)
In-Reply-To: <1038580321.15781949.1553708128337.JavaMail.zimbra@redhat.com>
On 3/27/19 5:35 PM, Bob Peterson wrote:
> Hi,
>
> Yesterday I posted a patch for this problem, but it was grossly inadequate.
> This patch, version 2, is another attempt to fix it. Many thanks to Ross
> Lagerwall for helping us identify, fix, and test the problem.
>
> Regards,
>
> Bob Peterson
> ---
> gfs2: clean_journal was setting sd_log_flush_head replaying other journals
>
> Function clean_journal was setting the value of sd_log_flush_head,
> but that's only a valid thing to do if it is replaying its own journal.
> If it's replaying another node's journal, that's completely wrong and
> will lead to multiple problems. This patch tries to clean up the
> mess by passing the value of head to gfs2_write_log_header so it can
> treat non-owned journals fairly.
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
This does seem to fix the issue. Thanks!
Tested-by: Ross Lagerwall <ross.lagerwall@citrix.com>
prev parent reply other threads:[~2019-03-28 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1269626391.15781367.1553707767750.JavaMail.zimbra@redhat.com>
2019-03-27 17:35 ` [Cluster-devel] [GFS2 PATCH V2] gfs2: clean_journal was setting sd_log_flush_head replaying other journals Bob Peterson
2019-03-28 11:58 ` Ross Lagerwall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=018cefb1-85c6-36cd-9154-f8e9729d3db7@citrix.com \
--to=ross.lagerwall@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).