From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Mon, 5 Mar 2018 19:15:19 +0000 Subject: [Cluster-devel] [PATCH 17/20] libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in, out} In-Reply-To: <1890018040.7997557.1520276448893.JavaMail.zimbra@redhat.com> References: <20180305182549.17817-1-anprice@redhat.com> <20180305182549.17817-18-anprice@redhat.com> <1890018040.7997557.1520276448893.JavaMail.zimbra@redhat.com> Message-ID: <088774c7-6614-2d89-2e85-1ffc9983f015@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 05/03/18 19:00, Bob Peterson wrote: > ----- Original Message ----- > | Signed-off-by: Andrew Price > | --- > | gfs2/edit/gfs2hex.c | 2 +- > | gfs2/edit/journal.c | 21 +++++++++------------ > | gfs2/libgfs2/libgfs2.h | 6 ++---- > | gfs2/libgfs2/ondisk.c | 15 ++++++--------- > | 4 files changed, 18 insertions(+), 26 deletions(-) > | +extern void gfs2_log_descriptor_out(struct gfs2_log_descriptor *ld, char > | *buf); > > Hm. Looks like gfs2_log_descriptor_out isn't used by any of the utils. > > We went through a phase where we tried to trim down libgfs2 in favor of > moving functions like this to the gfs2-util that uses it, in cases where > only one tool used it. Perhaps we should get rid of it altogether? > Unless you want to keep it in case third party tools link it in. Yes, I thought about that but I figured it doesn't add a large amount of burden and it would be an inconvenience to not have it there for times when we do need to print out a ld/qc, even just for debugging. That said, in the medium term I'd like to replace the _out, _in, and _print functions with something more generic and portable. I've thrown a few ideas out already for being too hackish or slow but these patches could make it a little easier to implement a better solution. Andy