From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 11 Aug 2011 17:03:14 -0400 (EDT) Subject: [Cluster-devel] [Patch 12/44] fsck.gfs2: get rid of triple negative logic Message-ID: <1053287010.544701.1313096594466.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit >From 62d7423184da8e291396cb54269612d501437006 Mon Sep 17 00:00:00 2001 From: Bob Peterson Date: Mon, 8 Aug 2011 14:44:46 -0500 Subject: [PATCH 12/44] fsck.gfs2: get rid of triple negative logic This patch changes the logic of the code from being triple-negative to single-negative so it won't twist your brain into knots. rhbz#675723 --- gfs2/fsck/metawalk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c index f2cd938..a4d7d3e 100644 --- a/gfs2/fsck/metawalk.c +++ b/gfs2/fsck/metawalk.c @@ -930,7 +930,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block, uint8_t q; struct duptree *d; - if (!valid_block(ip->i_sbd, block) != 0) + if (!valid_block(ip->i_sbd, block)) return -EFAULT; q = block_type(block); -- 1.7.4.4