From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Peterson <rpeterso@redhat.com>
Date: Mon, 14 Jan 2019 11:27:36 -0500 (EST)
Subject: [Cluster-devel] [PATCH 10/11] gfs2: Clean up assertion,
 consistency check, and error reporting functions
In-Reply-To: <20190111160548.9423-11-agruenba@redhat.com>
References: <20190111160548.9423-1-agruenba@redhat.com>
	<20190111160548.9423-11-agruenba@redhat.com>
Message-ID: <1074017165.64216881.1547483256047.JavaMail.zimbra@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

----- Original Message -----
> Instead of passing the __func__, __FILE__, and __LINE__ pre-processor macros
> to
> each of those functions, print the location of the caller via:
> 
>   printk(%pS", (void *)_RET_IP_).
> 
> This gives enough context information to locate where in the code an error
> occurred, and reduces the code size by about 2 percent.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---

Hi,

Sorry, but I don't like this patch at all.

With all the different versions floating around, and further obscured by static
function optimization by the compiler, this patch just makes debugging harder.
Not impossible, but harder.

In other words, in my opinion, the benefit is not worth the cost.

Plus it has nothing to do with making the rgrp bitmaps read in on-demand.

Regards,

Bob Peterson