From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Fix loop in gfs2_rbm_find (2)
Date: Thu, 24 Jan 2019 13:32:32 -0500 (EST) [thread overview]
Message-ID: <1104605356.66722605.1548354752398.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1511413108.66711908.1548351783052.JavaMail.zimbra@redhat.com>
----- Original Message -----
> ----- Original Message -----
> > The fix from commit 2d29f6b96d8f introduced an unexpected performance
> > regression when allocating blocks. Fix by rewriting the overly
> > complicated wrap-around logic in gfs2_rbm_find in a more reasonable way.
> > Discovered and verified with iozone.
> >
> > Fixes: 2d29f6b96d8f ("gfs2: Fix loop in gfs2_rbm_find")
> > Cc: stable at vger.kernel.org # v3.13+
> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
(snip)
> With this new patch, it will just go back next_bitmap, but there are no more
> bitmaps. It sets wrap, but since we're at the end, it returns -ENOSPC, when,
> in fact, there is a free block, no?
On closer inspection, the patch looks okay to me.
I still want to test it before we push it.
Bob Peterson
next prev parent reply other threads:[~2019-01-24 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 15:57 [Cluster-devel] [PATCH] gfs2: Fix loop in gfs2_rbm_find (2) Andreas Gruenbacher
2019-01-24 17:43 ` Bob Peterson
2019-01-24 18:32 ` Bob Peterson [this message]
2019-01-29 0:35 ` Sasha Levin
2019-01-30 20:39 ` Bob Peterson
-- strict thread matches above, loose matches on Subject: below --
2019-01-31 14:42 Andreas Gruenbacher
2019-02-02 14:38 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104605356.66722605.1548354752398.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).