From: Wendy Cheng <wcheng@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [NFS] [RFC PATCH 1/3] NLM lock failover - lock release
Date: Thu, 29 Jun 2006 23:57:10 -0400 [thread overview]
Message-ID: <1151639830.5642.23.camel@localhost.localdomain> (raw)
In-Reply-To: <1151622397.6405.5.camel@lade.trondhjem.org>
On Thu, 2006-06-29 at 19:06 -0400, Trond Myklebust wrote:
> >
> > + /* add server ip for nlm lock failover */
> > + sock->ops->getname(sock, (struct sockaddr *)&daddr, &alen, 0);
> > + rqstp->rq_daddr = daddr.sin_addr.s_addr;
> > +
>
> Hmm.... Why would you want to do this on every receive when you could
> just store the ip address in the struct svc_sock once and for all?
ok, will do that - save latency. Thanks.
>
> That said, how do you envisage this working in the cases where the
> socket is bound to INADDR_ANY?
This is "our" (server's) address, not peer address - for this request to
arrive "here", it can't be INADDR_ANY. Can it ? Remember "rq_daddr" will
only be used during failover in a clustered NFS servers environment.
-- Wendy
next prev parent reply other threads:[~2006-06-30 3:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-29 18:11 [Cluster-devel] [RFC PATCH 1/3] NLM lock failover - lock release Wendy Cheng
2006-06-29 19:11 ` [Cluster-devel] Re: [NFS] " Chuck Lever
2006-06-29 21:49 ` Wendy Cheng
2006-06-29 23:06 ` Trond Myklebust
2006-06-30 3:57 ` Wendy Cheng [this message]
[not found] ` <message from Wendy Cheng on Thursday June 29>
2006-06-30 4:15 ` Neil Brown
2006-06-30 4:38 ` Trond Myklebust
[not found] ` <message from Trond Myklebust on Friday June 30>
2006-06-30 5:00 ` Neil Brown
2006-06-30 4:39 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151639830.5642.23.camel@localhost.localdomain \
--to=wcheng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).