From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wendy Cheng Date: Thu, 29 Jun 2006 23:57:10 -0400 Subject: [Cluster-devel] Re: [NFS] [RFC PATCH 1/3] NLM lock failover - lock release In-Reply-To: <1151622397.6405.5.camel@lade.trondhjem.org> References: <44A417E7.5090500@redhat.com> <1151622397.6405.5.camel@lade.trondhjem.org> Message-ID: <1151639830.5642.23.camel@localhost.localdomain> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 2006-06-29 at 19:06 -0400, Trond Myklebust wrote: > > > > + /* add server ip for nlm lock failover */ > > + sock->ops->getname(sock, (struct sockaddr *)&daddr, &alen, 0); > > + rqstp->rq_daddr = daddr.sin_addr.s_addr; > > + > > Hmm.... Why would you want to do this on every receive when you could > just store the ip address in the struct svc_sock once and for all? ok, will do that - save latency. Thanks. > > That said, how do you envisage this working in the cases where the > socket is bound to INADDR_ANY? This is "our" (server's) address, not peer address - for this request to arrive "here", it can't be INADDR_ANY. Can it ? Remember "rq_daddr" will only be used during failover in a clustered NFS servers environment. -- Wendy