* [Cluster-devel] [PATCH 6/8] [GFS2] fs/gfs2/dir.c:gfs2_dir_write_data(): don't use an uninitialized variable
@ 2006-10-20 9:18 Steven Whitehouse
0 siblings, 0 replies; only message in thread
From: Steven Whitehouse @ 2006-10-20 9:18 UTC (permalink / raw)
To: cluster-devel.redhat.com
From 348acd48f050f5ba7fa917b1421ae34443be97dd Mon Sep 17 00:00:00 2001
From: Adrian Bunk <bunk@stusta.de>
Date: Thu, 19 Oct 2006 15:20:04 +0200
Subject: [GFS2] fs/gfs2/dir.c:gfs2_dir_write_data(): don't use an uninitialized variable
In the "if (extlen)" case, "new" might be used uninitialized.
Looking at the code, it should be initialized to 0.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
---
fs/gfs2/dir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index ce52bd9..ead7df0 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -184,7 +184,7 @@ static int gfs2_dir_write_data(struct gf
while (copied < size) {
unsigned int amount;
struct buffer_head *bh;
- int new;
+ int new = 0;
amount = size - copied;
if (amount > sdp->sd_sb.sb_bsize - o)
--
1.4.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-10-20 9:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-20 9:18 [Cluster-devel] [PATCH 6/8] [GFS2] fs/gfs2/dir.c:gfs2_dir_write_data(): don't use an uninitialized variable Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).