From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <steve@chygwyn.com>
Date: Mon, 30 Oct 2006 14:57:14 +0000
Subject: [Cluster-devel] Re: [PATCH] nfs: Fix nfs_readpages() error path
In-Reply-To: <1162159086.5545.70.camel@lade.trondhjem.org>
References: <877iyjundz.fsf@duaron.myhome.or.jp>
	<1162149038.5545.37.camel@lade.trondhjem.org>
	<87pscaua7p.fsf@duaron.myhome.or.jp>
	<1162159086.5545.70.camel@lade.trondhjem.org>
Message-ID: <1162220234.27980.274.camel@quoit.chygwyn.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Sun, 2006-10-29 at 16:58 -0500, Trond Myklebust wrote:
> On Mon, 2006-10-30 at 05:40 +0900, OGAWA Hirofumi wrote:
> > Well, both seems right things for me. So, the patch was done by
> > minimum change for -rc. If you want it, I'll do.
> 
> Feel free. I should have time to work on it tomorrow, in case you don't
> find time today.
> 
> > BTW, umm.. now I think, gfs2_readpages() seems to have a bug in error
> > path by different way. unlock_page() is really needed?
> 
> That looks like a definite bug too.
> 
> Cheers,
>   Trond

Agreed. It will be fixed fairly shortly as part of a patch related to a
race when reading and truncating "stuffed" files,

Steve.