From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 12 Sep 2012 09:40:31 -0400 (EDT) Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Fix infinite loop in rbm_find In-Reply-To: <9895789.14119266.1347456793090.JavaMail.root@redhat.com> Message-ID: <1168313838.14135115.1347457231752.JavaMail.root@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, This patch fixes an infinite loop in gfs2_rbm_find that was introduced by the previous patch. The problem occurred when the length was less than 3 but the rbm block was byte-aligned, causing it to improperly return a extent length of zero, which caused it to spin. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson --- fs/gfs2/rgrp.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index b933cdc..3cc402c 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -329,6 +329,7 @@ static u32 gfs2_free_extlen(const struct gfs2_rbm *rrbm, u32 len) gfs2_unaligned_extlen(&rbm, 4 - n_unaligned, &len)) goto out; + n_unaligned = len & 3; /* Start is now byte aligned */ while (len > 3) { start = rbm.bi->bi_bh->b_data;