cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] [GFS2] Fix demotion criteria in clear_glock
@ 2007-02-01 13:07 Steven Whitehouse
  0 siblings, 0 replies; only message in thread
From: Steven Whitehouse @ 2007-02-01 13:07 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hi,

It seems that the drop locks callback was causing a problem by trying to
demote locks which are still part of transactions. This patch means that
we will now ignore locks which are still in use in a transaction when
looking for demotion candidates.

Steve.


diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 6618c11..82bd64b 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1791,6 +1791,7 @@ static void clear_glock(struct gfs2_glock *gl)
 
 	if (gfs2_glmutex_trylock(gl)) {
 		if (list_empty(&gl->gl_holders) &&
+		    !atomic_read(&gl->gl_ail_count) &&
 		    gl->gl_state != LM_ST_UNLOCKED)
 			handle_callback(gl, LM_ST_UNLOCKED);
 		gfs2_glmutex_unlock(gl);




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-01 13:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-01 13:07 [Cluster-devel] [GFS2] Fix demotion criteria in clear_glock Steven Whitehouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).