* [Cluster-devel] [GFS2 patch] fix locking mistake
@ 2007-02-20 5:03 Josef Whiter
2007-02-21 22:37 ` Andrew Morton
2007-02-21 22:39 ` Steven Whitehouse
0 siblings, 2 replies; 3+ messages in thread
From: Josef Whiter @ 2007-02-20 5:03 UTC (permalink / raw)
To: cluster-devel.redhat.com
This patch fixes a locking mistake in the quota code, we do a mutex_lock instead
of a mutex_unlock.
Signed-off-by: Josef Whiter <jwhiter@redhat.com>
--- linux-2.6/fs/gfs2/quota.c.josef 2007-02-20 00:41:23.000000000 -0500
+++ linux-2.6/fs/gfs2/quota.c 2007-02-20 00:51:58.000000000 -0500
@@ -279,7 +279,7 @@ static int bh_get(struct gfs2_quota_data
(bh->b_data + sizeof(struct gfs2_meta_header) +
offset * sizeof(struct gfs2_quota_change));
- mutex_lock(&sdp->sd_quota_mutex);
+ mutex_unlock(&sdp->sd_quota_mutex);
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] [GFS2 patch] fix locking mistake
2007-02-20 5:03 [Cluster-devel] [GFS2 patch] fix locking mistake Josef Whiter
@ 2007-02-21 22:37 ` Andrew Morton
2007-02-21 22:39 ` Steven Whitehouse
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2007-02-21 22:37 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Tue, 20 Feb 2007 00:03:29 -0500
Josef Whiter <jwhiter@redhat.com> wrote:
> This patch fixes a locking mistake in the quota code, we do a mutex_lock instead
> of a mutex_unlock.
>
> Signed-off-by: Josef Whiter <jwhiter@redhat.com>
>
> --- linux-2.6/fs/gfs2/quota.c.josef 2007-02-20 00:41:23.000000000 -0500
> +++ linux-2.6/fs/gfs2/quota.c 2007-02-20 00:51:58.000000000 -0500
> @@ -279,7 +279,7 @@ static int bh_get(struct gfs2_quota_data
> (bh->b_data + sizeof(struct gfs2_meta_header) +
> offset * sizeof(struct gfs2_quota_change));
>
> - mutex_lock(&sdp->sd_quota_mutex);
> + mutex_unlock(&sdp->sd_quota_mutex);
>
> return 0;
>
whaaa? There's no way that any of that code has ever been executed, surely??
Oh well, I'll tag this for consideration by the -stable team.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Cluster-devel] [GFS2 patch] fix locking mistake
2007-02-20 5:03 [Cluster-devel] [GFS2 patch] fix locking mistake Josef Whiter
2007-02-21 22:37 ` Andrew Morton
@ 2007-02-21 22:39 ` Steven Whitehouse
1 sibling, 0 replies; 3+ messages in thread
From: Steven Whitehouse @ 2007-02-21 22:39 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the gfs2 git tree, sorry for the delay. Thanks,
Steve.
On Tue, 2007-02-20 at 00:03 -0500, Josef Whiter wrote:
> This patch fixes a locking mistake in the quota code, we do a mutex_lock instead
> of a mutex_unlock.
>
> Signed-off-by: Josef Whiter <jwhiter@redhat.com>
>
> --- linux-2.6/fs/gfs2/quota.c.josef 2007-02-20 00:41:23.000000000 -0500
> +++ linux-2.6/fs/gfs2/quota.c 2007-02-20 00:51:58.000000000 -0500
> @@ -279,7 +279,7 @@ static int bh_get(struct gfs2_quota_data
> (bh->b_data + sizeof(struct gfs2_meta_header) +
> offset * sizeof(struct gfs2_quota_change));
>
> - mutex_lock(&sdp->sd_quota_mutex);
> + mutex_unlock(&sdp->sd_quota_mutex);
>
> return 0;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-21 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-20 5:03 [Cluster-devel] [GFS2 patch] fix locking mistake Josef Whiter
2007-02-21 22:37 ` Andrew Morton
2007-02-21 22:39 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).