cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2] NFS filehandle check [3/12]
Date: Wed, 07 Mar 2007 14:27:59 +0000	[thread overview]
Message-ID: <1173277679.11001.758.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <1173277501.11001.752.camel@quoit.chygwyn.com>

From a7d2b2bdc9a0b55d5b08e15756c7e65c48c4bca5 Mon Sep 17 00:00:00 2001
From: Wendy Cheng <wcheng@redhat.com>
Date: Fri, 23 Feb 2007 00:21:17 -0500
Subject: [PATCH] [GFS2] NFS filehandle check

File handle checking error found in '07 NFS connectathon. The fh_type
and fh_len are not necessarily identical. Some of the client machines
could fail mount with stale filehandle without this patch.

Signed-off-by: S. Wendy Cheng <wcheng@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/ops_export.c b/fs/gfs2/ops_export.c
index 1de05b6..aad9183 100644
--- a/fs/gfs2/ops_export.c
+++ b/fs/gfs2/ops_export.c
@@ -38,14 +38,11 @@ static struct dentry *gfs2_decode_fh(struct super_block *sb,
 	struct gfs2_fh_obj fh_obj;
 	struct gfs2_inum_host *this, parent;
 
-	if (fh_type != fh_len)
-		return NULL;
-
 	this 		= &fh_obj.this;
 	fh_obj.imode 	= DT_UNKNOWN;
 	memset(&parent, 0, sizeof(struct gfs2_inum));
 
-	switch (fh_type) {
+	switch (fh_len) {
 	case GFS2_LARGE_FH_SIZE:
 		parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32;
 		parent.no_formal_ino |= be32_to_cpu(fh[5]);
-- 
1.4.4.2





  parent reply	other threads:[~2007-03-07 14:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-07 14:25 [Cluster-devel] [GFS2/DLM] Bug fixes [0/12] Steven Whitehouse
2007-03-07 14:26 ` [Cluster-devel] [GFS2] fix locking mistake [1/12] Steven Whitehouse
2007-03-07 14:27 ` [Cluster-devel] [GFS2] add newline to printk message [2/12] Steven Whitehouse
2007-03-07 14:27 ` Steven Whitehouse [this message]
2007-03-07 14:28 ` [Cluster-devel] [GFS2] fix hangup when multiple processes are trying to write to the same file [4/12] Steven Whitehouse
2007-03-07 14:29 ` [Cluster-devel] [DLM] fs/dlm/user.c should #include "user.h" [5/12] Steven Whitehouse
2007-03-07 14:30 ` [Cluster-devel] [GFS2] pass formal ino in do_filldir_main [6/12] Steven Whitehouse
2007-03-07 14:31 ` [Cluster-devel] [GFS2] Fix bz 230143, incorrect flushing of rgrps [7/12] Steven Whitehouse
2007-03-07 14:31 ` [Cluster-devel] [GFS2] Fix bz 229831, lookup returns wrong inode [8/12] Steven Whitehouse
2007-03-07 14:32 ` [Cluster-devel] [GFS2] Remove unused variable [9/12] Steven Whitehouse
2007-03-07 14:32 ` [Cluster-devel] [GFS2] go_drop_bh is never used, so remove it [10/12] Steven Whitehouse
2007-03-07 14:33 ` [Cluster-devel] [GFS2] build fix [11/12] Steven Whitehouse
2007-03-07 14:34 ` [Cluster-devel] [GFS2] Fix bz 229873, alternate test: assertion "!ip->i_inode.i_mapping->nrpages" failed [12/12] Steven Whitehouse
2007-03-07 14:43 ` [Cluster-devel] [GFS2/DLM] Pull request Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173277679.11001.758.camel@quoit.chygwyn.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).