From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2] Fix bz 229831, lookup returns wrong inode [8/12]
Date: Wed, 07 Mar 2007 14:31:44 +0000 [thread overview]
Message-ID: <1173277904.11001.768.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <1173277501.11001.752.camel@quoit.chygwyn.com>
From 1be3867955731b5cb2dc14060cc46f0882e87873 Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Thu, 1 Mar 2007 10:00:53 +0000
Subject: [PATCH] [GFS2] Fix bz 229831, lookup returns wrong inode
The following patch fixes Red Hat bz 229831. Without this patch its
possible for the wrong inode to be returned in certain cases. It is a
pretty unusual event, so that its taken some time to track down. Thanks
and due to Josef Whiter who did a lot of the testing required to thrack
this down and fix it.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 902dd81..df0b8b3 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -43,7 +43,8 @@ static int iget_test(struct inode *inode, void *opaque)
struct gfs2_inode *ip = GFS2_I(inode);
struct gfs2_inum_host *inum = opaque;
- if (ip->i_num.no_addr == inum->no_addr)
+ if (ip->i_num.no_addr == inum->no_addr &&
+ inode->i_private != NULL)
return 1;
return 0;
--
1.4.4.2
next prev parent reply other threads:[~2007-03-07 14:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 14:25 [Cluster-devel] [GFS2/DLM] Bug fixes [0/12] Steven Whitehouse
2007-03-07 14:26 ` [Cluster-devel] [GFS2] fix locking mistake [1/12] Steven Whitehouse
2007-03-07 14:27 ` [Cluster-devel] [GFS2] add newline to printk message [2/12] Steven Whitehouse
2007-03-07 14:27 ` [Cluster-devel] [GFS2] NFS filehandle check [3/12] Steven Whitehouse
2007-03-07 14:28 ` [Cluster-devel] [GFS2] fix hangup when multiple processes are trying to write to the same file [4/12] Steven Whitehouse
2007-03-07 14:29 ` [Cluster-devel] [DLM] fs/dlm/user.c should #include "user.h" [5/12] Steven Whitehouse
2007-03-07 14:30 ` [Cluster-devel] [GFS2] pass formal ino in do_filldir_main [6/12] Steven Whitehouse
2007-03-07 14:31 ` [Cluster-devel] [GFS2] Fix bz 230143, incorrect flushing of rgrps [7/12] Steven Whitehouse
2007-03-07 14:31 ` Steven Whitehouse [this message]
2007-03-07 14:32 ` [Cluster-devel] [GFS2] Remove unused variable [9/12] Steven Whitehouse
2007-03-07 14:32 ` [Cluster-devel] [GFS2] go_drop_bh is never used, so remove it [10/12] Steven Whitehouse
2007-03-07 14:33 ` [Cluster-devel] [GFS2] build fix [11/12] Steven Whitehouse
2007-03-07 14:34 ` [Cluster-devel] [GFS2] Fix bz 229873, alternate test: assertion "!ip->i_inode.i_mapping->nrpages" failed [12/12] Steven Whitehouse
2007-03-07 14:43 ` [Cluster-devel] [GFS2/DLM] Pull request Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173277904.11001.768.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).