* [Cluster-devel] [GFS2] fix bz 231369, gfs2 will oops if you specify an invalid mount option
@ 2007-03-07 22:09 Josef Whiter
2007-03-07 22:25 ` Robert Peterson
2007-03-08 9:34 ` Steven Whitehouse
0 siblings, 2 replies; 3+ messages in thread
From: Josef Whiter @ 2007-03-07 22:09 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hello,
If you specify an invalid mount option when trying to mount a gfs2 filesystem,
gfs2 will oops. The attached patch resolves this problem.
Signed-off-by: Josef Whiter <jwhiter@redhat.com>
--- gfs2-2.6-nmw/fs/gfs2/glock.c.josef 2007-03-07 17:05:39.000000000 -0500
+++ gfs2-2.6-nmw/fs/gfs2/glock.c 2007-03-07 17:06:13.000000000 -0500
@@ -2217,7 +2217,7 @@ int gfs2_create_debugfs_file(struct gfs2
void gfs2_delete_debugfs_file(struct gfs2_sbd *sdp)
{
- if (sdp->debugfs_dentry)
+ if (sdp && sdp->debugfs_dentry)
debugfs_remove(sdp->debugfs_dentry);
}
^ permalink raw reply [flat|nested] 3+ messages in thread* [Cluster-devel] [GFS2] fix bz 231369, gfs2 will oops if you specify an invalid mount option
2007-03-07 22:09 [Cluster-devel] [GFS2] fix bz 231369, gfs2 will oops if you specify an invalid mount option Josef Whiter
@ 2007-03-07 22:25 ` Robert Peterson
2007-03-08 9:34 ` Steven Whitehouse
1 sibling, 0 replies; 3+ messages in thread
From: Robert Peterson @ 2007-03-07 22:25 UTC (permalink / raw)
To: cluster-devel.redhat.com
Josef Whiter wrote:
> Hello,
>
> If you specify an invalid mount option when trying to mount a gfs2 filesystem,
> gfs2 will oops. The attached patch resolves this problem.
>
> Signed-off-by: Josef Whiter <jwhiter@redhat.com>
>
>
> --- gfs2-2.6-nmw/fs/gfs2/glock.c.josef 2007-03-07 17:05:39.000000000 -0500
> +++ gfs2-2.6-nmw/fs/gfs2/glock.c 2007-03-07 17:06:13.000000000 -0500
> @@ -2217,7 +2217,7 @@ int gfs2_create_debugfs_file(struct gfs2
>
> void gfs2_delete_debugfs_file(struct gfs2_sbd *sdp)
> {
> - if (sdp->debugfs_dentry)
> + if (sdp && sdp->debugfs_dentry)
> debugfs_remove(sdp->debugfs_dentry);
> }
ACK
Bob Peterson
Red Hat Cluster Suite
^ permalink raw reply [flat|nested] 3+ messages in thread* [Cluster-devel] [GFS2] fix bz 231369, gfs2 will oops if you specify an invalid mount option
2007-03-07 22:09 [Cluster-devel] [GFS2] fix bz 231369, gfs2 will oops if you specify an invalid mount option Josef Whiter
2007-03-07 22:25 ` Robert Peterson
@ 2007-03-08 9:34 ` Steven Whitehouse
1 sibling, 0 replies; 3+ messages in thread
From: Steven Whitehouse @ 2007-03-08 9:34 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the gfs2 -nmw git tree. Thanks,
Steve.
On Wed, 2007-03-07 at 17:09 -0500, Josef Whiter wrote:
> Hello,
>
> If you specify an invalid mount option when trying to mount a gfs2 filesystem,
> gfs2 will oops. The attached patch resolves this problem.
>
> Signed-off-by: Josef Whiter <jwhiter@redhat.com>
>
>
> --- gfs2-2.6-nmw/fs/gfs2/glock.c.josef 2007-03-07 17:05:39.000000000 -0500
> +++ gfs2-2.6-nmw/fs/gfs2/glock.c 2007-03-07 17:06:13.000000000 -0500
> @@ -2217,7 +2217,7 @@ int gfs2_create_debugfs_file(struct gfs2
>
> void gfs2_delete_debugfs_file(struct gfs2_sbd *sdp)
> {
> - if (sdp->debugfs_dentry)
> + if (sdp && sdp->debugfs_dentry)
> debugfs_remove(sdp->debugfs_dentry);
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-08 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-07 22:09 [Cluster-devel] [GFS2] fix bz 231369, gfs2 will oops if you specify an invalid mount option Josef Whiter
2007-03-07 22:25 ` Robert Peterson
2007-03-08 9:34 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).