* [Cluster-devel] [PATCH] dlm: fix coverity-spotted stupidity
[not found] <1174562653.32601.172.camel@quoit.chygwyn.com>
@ 2007-03-22 11:49 ` Patrick Caulfield
2007-03-22 12:14 ` [Cluster-devel] " Steven Whitehouse
0 siblings, 1 reply; 7+ messages in thread
From: Patrick Caulfield @ 2007-03-22 11:49 UTC (permalink / raw)
To: cluster-devel.redhat.com
This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works.
Thanks to Adrian Bunk & the coverity checker for spotting that
Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
--
patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ret.patch
Type: text/x-patch
Size: 480 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070322/2e513022/attachment.bin>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Cluster-devel] Re: [PATCH] dlm: fix coverity-spotted stupidity
2007-03-22 11:49 ` [Cluster-devel] [PATCH] dlm: fix coverity-spotted stupidity Patrick Caulfield
@ 2007-03-22 12:14 ` Steven Whitehouse
2007-03-23 20:59 ` Abhijith Das
0 siblings, 1 reply; 7+ messages in thread
From: Steven Whitehouse @ 2007-03-22 12:14 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now applied to the -nmw git tree. Thanks,
Steve.
On Thu, 2007-03-22 at 11:49 +0000, Patrick Caulfield wrote:
> This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works.
> Thanks to Adrian Bunk & the coverity checker for spotting that
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Cluster-devel] Re: [PATCH] dlm: fix coverity-spotted stupidity
2007-03-22 12:14 ` [Cluster-devel] " Steven Whitehouse
@ 2007-03-23 20:59 ` Abhijith Das
2007-03-26 7:35 ` Patrick Caulfield
0 siblings, 1 reply; 7+ messages in thread
From: Abhijith Das @ 2007-03-23 20:59 UTC (permalink / raw)
To: cluster-devel.redhat.com
Steven Whitehouse wrote:
>Hi,
>
>Now applied to the -nmw git tree. Thanks,
>
>Steve.
>
>On Thu, 2007-03-22 at 11:49 +0000, Patrick Caulfield wrote:
>
>
>>This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually works.
>>Thanks to Adrian Bunk & the coverity checker for spotting that
>>
>>Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>>
Hi,
I pulled this patch along with the latest stuff from the nmw tree. Looks
like this patch makes dlm_recv/0 use 100% CPU. I'm not able to restart
clvmd and such. I'm guessing the kernel_recvmsg() keeps returning
-EAGAIN and we keep rescheduling. Any clue as to what is going on?
Thanks,
--Abhi
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Cluster-devel] Re: [PATCH] dlm: fix coverity-spotted stupidity
2007-03-23 20:59 ` Abhijith Das
@ 2007-03-26 7:35 ` Patrick Caulfield
2007-03-26 8:18 ` Steven Whitehouse
2007-03-26 8:56 ` Patrick Caulfield
0 siblings, 2 replies; 7+ messages in thread
From: Patrick Caulfield @ 2007-03-26 7:35 UTC (permalink / raw)
To: cluster-devel.redhat.com
Abhijith Das wrote:
> Steven Whitehouse wrote:
>
>> Hi,
>>
>> Now applied to the -nmw git tree. Thanks,
>>
>> Steve.
>>
>> On Thu, 2007-03-22 at 11:49 +0000, Patrick Caulfield wrote:
>>
>>
>>> This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually
>>> works.
>>> Thanks to Adrian Bunk & the coverity checker for spotting that
>>>
>>> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>>>
> Hi,
> I pulled this patch along with the latest stuff from the nmw tree. Looks
> like this patch makes dlm_recv/0 use 100% CPU. I'm not able to restart
> clvmd and such. I'm guessing the kernel_recvmsg() keeps returning
> -EAGAIN and we keep rescheduling. Any clue as to what is going on?
Bugger. You're right.
--
patrick
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Cluster-devel] Re: [PATCH] dlm: fix coverity-spotted stupidity
2007-03-26 7:35 ` Patrick Caulfield
@ 2007-03-26 8:18 ` Steven Whitehouse
2007-03-26 8:56 ` Patrick Caulfield
1 sibling, 0 replies; 7+ messages in thread
From: Steven Whitehouse @ 2007-03-26 8:18 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Since I'm just updating the git tree due to 2.6.21-rc5, I've pulled this
patch for now,
Steve.
On Mon, 2007-03-26 at 08:35 +0100, Patrick Caulfield wrote:
> Abhijith Das wrote:
> > Steven Whitehouse wrote:
> >
> >> Hi,
> >>
> >> Now applied to the -nmw git tree. Thanks,
> >>
> >> Steve.
> >>
> >> On Thu, 2007-03-22 at 11:49 +0000, Patrick Caulfield wrote:
> >>
> >>
> >>> This patch fixes the EAGAIN checking in lowcomms-tcp.c so it actually
> >>> works.
> >>> Thanks to Adrian Bunk & the coverity checker for spotting that
> >>>
> >>> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
> >>>
> > Hi,
> > I pulled this patch along with the latest stuff from the nmw tree. Looks
> > like this patch makes dlm_recv/0 use 100% CPU. I'm not able to restart
> > clvmd and such. I'm guessing the kernel_recvmsg() keeps returning
> > -EAGAIN and we keep rescheduling. Any clue as to what is going on?
>
>
> Bugger. You're right.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Cluster-devel] Re: [PATCH] dlm: fix coverity-spotted stupidity
2007-03-26 7:35 ` Patrick Caulfield
2007-03-26 8:18 ` Steven Whitehouse
@ 2007-03-26 8:56 ` Patrick Caulfield
2007-03-26 9:09 ` Steven Whitehouse
1 sibling, 1 reply; 7+ messages in thread
From: Patrick Caulfield @ 2007-03-26 8:56 UTC (permalink / raw)
To: cluster-devel.redhat.com
Replacement patch to remove redundant code rather than moving it around.
Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
--
patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: again.patch
Type: text/x-patch
Size: 342 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070326/3ffcf0e3/attachment.bin>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Cluster-devel] Re: [PATCH] dlm: fix coverity-spotted stupidity
2007-03-26 8:56 ` Patrick Caulfield
@ 2007-03-26 9:09 ` Steven Whitehouse
0 siblings, 0 replies; 7+ messages in thread
From: Steven Whitehouse @ 2007-03-26 9:09 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now applied to the -nmw git tree instead of the original patch. Thanks,
Steve.
On Mon, 2007-03-26 at 09:56 +0100, Patrick Caulfield wrote:
> Replacement patch to remove redundant code rather than moving it around.
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-03-26 9:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1174562653.32601.172.camel@quoit.chygwyn.com>
2007-03-22 11:49 ` [Cluster-devel] [PATCH] dlm: fix coverity-spotted stupidity Patrick Caulfield
2007-03-22 12:14 ` [Cluster-devel] " Steven Whitehouse
2007-03-23 20:59 ` Abhijith Das
2007-03-26 7:35 ` Patrick Caulfield
2007-03-26 8:18 ` Steven Whitehouse
2007-03-26 8:56 ` Patrick Caulfield
2007-03-26 9:09 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).