* [Cluster-devel] [PATCH] gfs2: use log_error before LM_OUT_ERROR
@ 2007-03-28 16:08 David Teigland
2007-03-28 16:13 ` [Cluster-devel] " Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: David Teigland @ 2007-03-28 16:08 UTC (permalink / raw)
To: cluster-devel.redhat.com
We always want to see the details of the error returned to gfs, but
log_debug is often turned off, so use log_error (printk).
Signed-off-by: David Teigland <teigland@redhat.com>
Index: linux-2.6.20-git2-quilt/fs/gfs2/locking/dlm/lock.c
===================================================================
--- linux-2.6.20-git2-quilt.orig/fs/gfs2/locking/dlm/lock.c 2007-02-04 12:44:54.000000000 -0600
+++ linux-2.6.20-git2-quilt/fs/gfs2/locking/dlm/lock.c 2007-03-28 11:02:00.000000000 -0500
@@ -268,7 +268,7 @@
}
if (error) {
- log_debug("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
+ log_error("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
"flags=%lx", ls->fsname, lp->lockname.ln_type,
(unsigned long long)lp->lockname.ln_number, error,
lp->cur, lp->req, lp->lkf, lp->flags);
@@ -296,7 +296,7 @@
error = dlm_unlock(ls->dlm_lockspace, lp->lksb.sb_lkid, lkf, NULL, lp);
if (error) {
- log_debug("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
+ log_error("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
"flags=%lx", ls->fsname, lp->lockname.ln_type,
(unsigned long long)lp->lockname.ln_number, error,
lp->cur, lp->req, lp->lkf, lp->flags);
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Cluster-devel] Re: [PATCH] gfs2: use log_error before LM_OUT_ERROR
2007-03-28 16:08 [Cluster-devel] [PATCH] gfs2: use log_error before LM_OUT_ERROR David Teigland
@ 2007-03-28 16:13 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2007-03-28 16:13 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On Wed, 2007-03-28 at 11:08 -0500, David Teigland wrote:
> We always want to see the details of the error returned to gfs, but
> log_debug is often turned off, so use log_error (printk).
>
> Signed-off-by: David Teigland <teigland@redhat.com>
>
> Index: linux-2.6.20-git2-quilt/fs/gfs2/locking/dlm/lock.c
> ===================================================================
> --- linux-2.6.20-git2-quilt.orig/fs/gfs2/locking/dlm/lock.c 2007-02-04 12:44:54.000000000 -0600
> +++ linux-2.6.20-git2-quilt/fs/gfs2/locking/dlm/lock.c 2007-03-28 11:02:00.000000000 -0500
> @@ -268,7 +268,7 @@
> }
>
> if (error) {
> - log_debug("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
> + log_error("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
> "flags=%lx", ls->fsname, lp->lockname.ln_type,
> (unsigned long long)lp->lockname.ln_number, error,
> lp->cur, lp->req, lp->lkf, lp->flags);
> @@ -296,7 +296,7 @@
> error = dlm_unlock(ls->dlm_lockspace, lp->lksb.sb_lkid, lkf, NULL, lp);
>
> if (error) {
> - log_debug("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
> + log_error("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
> "flags=%lx", ls->fsname, lp->lockname.ln_type,
> (unsigned long long)lp->lockname.ln_number, error,
> lp->cur, lp->req, lp->lkf, lp->flags);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-28 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-28 16:08 [Cluster-devel] [PATCH] gfs2: use log_error before LM_OUT_ERROR David Teigland
2007-03-28 16:13 ` [Cluster-devel] " Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).