From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Wed, 28 Mar 2007 17:13:32 +0100
Subject: [Cluster-devel] Re: [PATCH] gfs2: use log_error before LM_OUT_ERROR
In-Reply-To: <20070328160804.GE22230@redhat.com>
References: <20070328160804.GE22230@redhat.com>
Message-ID: <1175098412.1636.75.camel@quoit.chygwyn.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

Now in the -nmw git tree. Thanks,

Steve.

On Wed, 2007-03-28 at 11:08 -0500, David Teigland wrote:
> We always want to see the details of the error returned to gfs, but
> log_debug is often turned off, so use log_error (printk).
> 
> Signed-off-by: David Teigland <teigland@redhat.com>
> 
> Index: linux-2.6.20-git2-quilt/fs/gfs2/locking/dlm/lock.c
> ===================================================================
> --- linux-2.6.20-git2-quilt.orig/fs/gfs2/locking/dlm/lock.c	2007-02-04 12:44:54.000000000 -0600
> +++ linux-2.6.20-git2-quilt/fs/gfs2/locking/dlm/lock.c	2007-03-28 11:02:00.000000000 -0500
> @@ -268,7 +268,7 @@
>  	}
>  
>  	if (error) {
> -		log_debug("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
> +		log_error("%s: gdlm_lock %x,%llx err=%d cur=%d req=%d lkf=%x "
>  			  "flags=%lx", ls->fsname, lp->lockname.ln_type,
>  			  (unsigned long long)lp->lockname.ln_number, error,
>  			  lp->cur, lp->req, lp->lkf, lp->flags);
> @@ -296,7 +296,7 @@
>  	error = dlm_unlock(ls->dlm_lockspace, lp->lksb.sb_lkid, lkf, NULL, lp);
>  
>  	if (error) {
> -		log_debug("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
> +		log_error("%s: gdlm_unlock %x,%llx err=%d cur=%d req=%d lkf=%x "
>  			  "flags=%lx", ls->fsname, lp->lockname.ln_type,
>  			  (unsigned long long)lp->lockname.ln_number, error,
>  			  lp->cur, lp->req, lp->lkf, lp->flags);