cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] [DLM][PATCH] Fix dlm_lowcoms_stop hang
@ 2007-04-19 21:59 Josef Bacik
  2007-04-20  8:26 ` Steven Whitehouse
  0 siblings, 1 reply; 2+ messages in thread
From: Josef Bacik @ 2007-04-19 21:59 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hello,

When you attempt to release a lockspace in DLM, it will hang trying to down a
semaphore that has already been downed.  The attached patch fixes the problem.
Thank you,

Josef

Signed-off-by: Josef Bacik <jwhiter@redhat.com>

diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
index 76399b7..2b32f3c 100644
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -1407,7 +1407,7 @@ void dlm_lowcomms_stop(void)
 	clean_writequeues();
 
 	for (i = 0; i < max_nodeid; i++) {
-		con = nodeid2con(i, 0);
+		con = __nodeid2con(i, 0);
 		if (con) {
 			close_connection(con, true);
 			if (con->othercon)



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Cluster-devel] [DLM][PATCH] Fix dlm_lowcoms_stop hang
  2007-04-19 21:59 [Cluster-devel] [DLM][PATCH] Fix dlm_lowcoms_stop hang Josef Bacik
@ 2007-04-20  8:26 ` Steven Whitehouse
  0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2007-04-20  8:26 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Hi,

Now applied to the git tree. Thanks,

Steve.

On Thu, 2007-04-19 at 17:59 -0400, Josef Bacik wrote:
> Hello,
> 
> When you attempt to release a lockspace in DLM, it will hang trying to down a
> semaphore that has already been downed.  The attached patch fixes the problem.
> Thank you,
> 
> Josef
> 
> Signed-off-by: Josef Bacik <jwhiter@redhat.com>
> 
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 76399b7..2b32f3c 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -1407,7 +1407,7 @@ void dlm_lowcomms_stop(void)
>  	clean_writequeues();
>  
>  	for (i = 0; i < max_nodeid; i++) {
> -		con = nodeid2con(i, 0);
> +		con = __nodeid2con(i, 0);
>  		if (con) {
>  			close_connection(con, true);
>  			if (con->othercon)
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-04-20  8:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-19 21:59 [Cluster-devel] [DLM][PATCH] Fix dlm_lowcoms_stop hang Josef Bacik
2007-04-20  8:26 ` Steven Whitehouse

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).