* [Cluster-devel] DLM portion of commit 16e5c1fc needs reverting or fixing "convert a bunch of open-coded instances of memdup_user_nul()"
[not found] <80915500.13555461.1453413814636.JavaMail.zimbra@redhat.com>
@ 2016-01-21 22:13 ` Bob Peterson
0 siblings, 0 replies; only message in thread
From: Bob Peterson @ 2016-01-21 22:13 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Al, this change to fs/dlm/user.c is wrong and needs fixing:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/dlm/user.c?id=16e5c1fc36040e592128a164499bc25eb138a80f
There are two things:
- It uses !IS_ERR() where it should use IS_ERR()
- It doesn't set GFP_NOFS
Can you fix it please? Or do you want me to post a patch?
You might want to check the other changes in the set for similar things.
Regards,
Bob Peterson
Red Hat File Systems
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-21 22:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <80915500.13555461.1453413814636.JavaMail.zimbra@redhat.com>
2016-01-21 22:13 ` [Cluster-devel] DLM portion of commit 16e5c1fc needs reverting or fixing "convert a bunch of open-coded instances of memdup_user_nul()" Bob Peterson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).