From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Tue, 10 Jul 2007 11:01:55 +0100
Subject: [Cluster-devel] Re: [PATCH] [GFS2] Remove i_mode passing from NFS
	File Handle
In-Reply-To: <20070710090639.GA28029@infradead.org>
References: <11839970793713-git-send-email-swhiteho@redhat.com>
	<11839970813260-git-send-email-swhiteho@redhat.com>
	<11839970832750-git-send-email-swhiteho@redhat.com>
	<11839970852076-git-send-email-swhiteho@redhat.com>
	<11839970871671-git-send-email-swhiteho@redhat.com>
	<1183997089710-git-send-email-swhiteho@redhat.com>
	<11839970914023-git-send-email-swhiteho@redhat.com>
	<11839970921764-git-send-email-swhiteho@redhat.com>
	<11839970941232-git-send-email-swhiteho@redhat.com>
	<11839970963525-git-send-email-swhiteho@redhat.com>
	<20070710090639.GA28029@infradead.org>
Message-ID: <1184061715.8765.194.camel@quoit>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On Tue, 2007-07-10 at 10:06 +0100, Christoph Hellwig wrote:
> > -#define GFS2_LARGE_FH_SIZE 10
> > -
> > -struct gfs2_fh_obj {
> > -	struct gfs2_inum_host this;
> > -	u32 imode;
> > -};
> > +#define GFS2_LARGE_FH_SIZE 8
> 
> Because gfs2_decode_fh only accepts file handles with GFS2_LARGE_FH_SIZE
> or GFS2_LARGE_FH_SIZE you don't accept filehandles sent out by and older
> gfs version anymore.  Stale filehandles because of a new kernel version
> are a big no-no, so please add back code to handle the old filehandles
> on the decode side.
> 

This should fix that problem I think since its only relating to end of
the fh we can just ignore that field in order to accept the older
format,

Steve.

diff --git a/fs/gfs2/ops_export.c b/fs/gfs2/ops_export.c
index e317db2..99ea565 100644
--- a/fs/gfs2/ops_export.c
+++ b/fs/gfs2/ops_export.c
@@ -28,6 +28,7 @@
 
 #define GFS2_SMALL_FH_SIZE 4
 #define GFS2_LARGE_FH_SIZE 8
+#define GFS2_OLD_FH_SIZE 10
 
 static struct dentry *gfs2_decode_fh(struct super_block *sb,
 				     __u32 *p,
@@ -44,6 +45,7 @@ static struct dentry *gfs2_decode_fh(struct super_block *sb,
 
 	switch (fh_len) {
 	case GFS2_LARGE_FH_SIZE:
+	case GFS2_OLD_FH_SIZE:
 		parent.no_formal_ino = ((u64)be32_to_cpu(fh[4])) << 32;
 		parent.no_formal_ino |= be32_to_cpu(fh[5]);
 		parent.no_addr = ((u64)be32_to_cpu(fh[6])) << 32;