From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Tue, 10 Jul 2007 12:47:52 +0100 Subject: [Cluster-devel] Re: [PATCH] [GFS2] Remove i_mode passing from NFS File Handle In-Reply-To: <20070710113626.GA1191@infradead.org> References: <11839970832750-git-send-email-swhiteho@redhat.com> <11839970852076-git-send-email-swhiteho@redhat.com> <11839970871671-git-send-email-swhiteho@redhat.com> <1183997089710-git-send-email-swhiteho@redhat.com> <11839970914023-git-send-email-swhiteho@redhat.com> <11839970921764-git-send-email-swhiteho@redhat.com> <11839970941232-git-send-email-swhiteho@redhat.com> <11839970963525-git-send-email-swhiteho@redhat.com> <20070710090639.GA28029@infradead.org> <1184061715.8765.194.camel@quoit> <20070710113626.GA1191@infradead.org> Message-ID: <1184068072.8765.212.camel@quoit> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On Tue, 2007-07-10 at 12:36 +0100, Christoph Hellwig wrote: > On Tue, Jul 10, 2007 at 11:01:55AM +0100, Steven Whitehouse wrote: > > > Because gfs2_decode_fh only accepts file handles with GFS2_LARGE_FH_SIZE > > > or GFS2_LARGE_FH_SIZE you don't accept filehandles sent out by and older > > > gfs version anymore. Stale filehandles because of a new kernel version > > > are a big no-no, so please add back code to handle the old filehandles > > > on the decode side. > > > > > > > This should fix that problem I think since its only relating to end of > > the fh we can just ignore that field in order to accept the older > > format, > > Yes, I guess this should do it. I've just added it, with a signed-off-by: into the -nmw git tree, so I think the pull request can now continue to stand, Steve.