From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Tue, 24 Jul 2007 00:26:25 -0500 Subject: [Cluster-devel] [PATCH 5 of 5]Bz #248176: GFS2: invalid metadata block, gfs2_meta_indirect_buffer Message-ID: <1185254785.517.81.camel@technetium.msp.redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This is patch 5 of 5 for bug #248176 Metadata corruption was occurring because page references weren't being removed in all cases. I previously added a function called detach_bufdata, but I discovered there already WAS a function out there to do the job. It's called gfs2_meta_cache_flush. So I added a call to that to remove the page references. Recently I had been thinking that this was entirely unnecessary, but when I removed the code, the metadata corruption problem returned immediately. -- Signed-off-by: Bob Peterson -- --- a/log.c 2007-07-23 22:51:15.000000000 -0500 +++ b/log.c 2007-07-23 23:19:14.000000000 -0500 @@ -219,6 +219,7 @@ static void gfs2_ail2_empty_one(struct g { struct list_head *head = &ai->ai_ail2_list; struct gfs2_bufdata *bd; + struct gfs2_inode *bh_ip; while (!list_empty(head)) { bd = list_entry(head->prev, struct gfs2_bufdata, @@ -228,6 +229,8 @@ static void gfs2_ail2_empty_one(struct g list_del(&bd->bd_ail_st_list); list_del(&bd->bd_ail_gl_list); atomic_dec(&bd->bd_gl->gl_ail_count); + bh_ip = GFS2_I(bd->bd_bh->b_page->mapping->host); + gfs2_meta_cache_flush(bh_ip); brelse(bd->bd_bh); } }