From mboxrd@z Thu Jan  1 00:00:00 1970
From: Trond Myklebust <trond.myklebust@fys.uio.no>
Date: Mon, 06 Aug 2007 15:04:23 -0400
Subject: [Cluster-devel] Re: [fuse-devel] [PATCH 01/25] VFS: move attr_kill
	logic from notify_change into helper function
In-Reply-To: <E1II7JR-0005BN-00@dorka.pomaz.szeredi.hu>
References: <200708061354.l76Ds6sq002260@dantu.rdu.redhat.com>
	<E1II6cM-0004yj-00@dorka.pomaz.szeredi.hu>
	<20070806141333.0f54ab17.jlayton@redhat.com>
	<E1II7JR-0005BN-00@dorka.pomaz.szeredi.hu>
Message-ID: <1186427063.6616.59.camel@localhost>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Mon, 2007-08-06 at 20:28 +0200, Miklos Szeredi wrote:

> Your patch is changing the API in a very unsafe way, since there will
> be no error or warning on an unconverted fs.  And that could lead to
> security holes.
> 
> If we would rename the setattr method to setattr_new as well as
> changing it's behavior, that would be fine.  But I guess we do not
> want to do that.

Which "unconverted fses"? If we're talking out of tree stuff, then too
bad: it is _their_ responsibility to keep up with kernel changes.

Trond