* [Cluster-devel] [PATCH] gfs2: fixed a NULL pointer assignment BUG
@ 2007-08-15 15:54 Denis Cheng
2007-08-15 16:07 ` [Cluster-devel] " Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Denis Cheng @ 2007-08-15 15:54 UTC (permalink / raw)
To: cluster-devel.redhat.com
Signed-off-by: Denis Cheng <crquan@gmail.com>
---
fs/gfs2/ops_fstype.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index cf5aa50..67e2d43 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -301,8 +301,9 @@ static int init_sb(struct gfs2_sbd *sdp, int silent, int undo)
fs_err(sdp, "can't get root dentry\n");
error = -ENOMEM;
iput(inode);
- }
- sb->s_root->d_op = &gfs2_dops;
+ } else
+ sb->s_root->d_op = &gfs2_dops;
+
out:
gfs2_glock_dq_uninit(&sb_gh);
return error;
--
1.5.3.rc4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] Re: [PATCH] gfs2: fixed a NULL pointer assignment BUG
2007-08-15 15:54 [Cluster-devel] [PATCH] gfs2: fixed a NULL pointer assignment BUG Denis Cheng
@ 2007-08-15 16:07 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2007-08-15 16:07 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the GFS2 -nmw git tree. Thanks,
Steve.
On Wed, 2007-08-15 at 23:54 +0800, Denis Cheng wrote:
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> fs/gfs2/ops_fstype.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index cf5aa50..67e2d43 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -301,8 +301,9 @@ static int init_sb(struct gfs2_sbd *sdp, int silent, int undo)
> fs_err(sdp, "can't get root dentry\n");
> error = -ENOMEM;
> iput(inode);
> - }
> - sb->s_root->d_op = &gfs2_dops;
> + } else
> + sb->s_root->d_op = &gfs2_dops;
> +
> out:
> gfs2_glock_dq_uninit(&sb_gh);
> return error;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-15 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-15 15:54 [Cluster-devel] [PATCH] gfs2: fixed a NULL pointer assignment BUG Denis Cheng
2007-08-15 16:07 ` [Cluster-devel] " Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).